Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: 🤖 update host catalog ui #1342

Merged
merged 4 commits into from
Sep 20, 2022
Merged

chore: 🤖 update host catalog ui #1342

merged 4 commits into from
Sep 20, 2022

Conversation

DhariniJeeva
Copy link
Collaborator

@DhariniJeeva DhariniJeeva commented Sep 20, 2022 •
edited
Loading

jira

redirect pr

region updates:
Screen Shot 2022-09-20 at 12 49 17 PM

azure

@vercel
Copy link

vercel bot commented Sep 20, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
boundary-ui ✅ Ready (Inspect) Visit Preview Sep 20, 2022 at 8:08PM (UTC)
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview Sep 20, 2022 at 8:08PM (UTC)
boundary-ui-storybook ✅ Ready (Inspect) Visit Preview Sep 20, 2022 at 8:08PM (UTC)

@DhariniJeeva DhariniJeeva changed the title chore: 🤖 update host catalog/hosts/host-set azure texts chore: 🤖 update host catalog ui Sep 20, 2022
@DhariniJeeva DhariniJeeva marked this pull request as ready for review September 20, 2022 19:48
@DhariniJeeva DhariniJeeva requested a review from a team as a code owner September 20, 2022 19:48
ZedLi
ZedLi approved these changes Sep 20, 2022
View reviewed changes
Copy link
Collaborator

@ZedLi ZedLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left one comment

addons/core/translations/form/en-us.yaml Outdated Show resolved Hide resolved
cameronperera
cameronperera approved these changes Sep 20, 2022
View reviewed changes
Copy link
Collaborator

@cameronperera cameronperera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Ditto Zed's comment about the "Region" translation.

@DhariniJeeva DhariniJeeva merged commit 3f2a17f into main Sep 20, 2022
@DhariniJeeva DhariniJeeva deleted the ICU-5723-dhc-helper-text-in-ui branch September 20, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameronperera cameronperera cameronperera approved these changes

@ZedLi ZedLi ZedLi approved these changes

Assignees
No one assigned
Labels
addons admin ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DhariniJeeva @ZedLi @cameronperera