Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icu 5651 create spk type #1266

Merged
merged 23 commits into from
Aug 24, 2022
Merged

Icu 5651 create spk type #1266

merged 23 commits into from
Aug 24, 2022

Conversation

lisbet-alvarez
Copy link
Collaborator

@lisbet-alvarez lisbet-alvarez commented Aug 17, 2022 •
edited
Loading

🎟️ Jira ticket

🧑‍💻 Admin preview

Description

Add functionality for creating a ssh private key credential and add corresponding acceptance tests.

@lisbet-alvarez
feat: 🎸 Update the credentials route to support both types
bdf3901 
Add query param to the credential route in order to support the new ssh
private key type

✅ Closes: ICU-5649
@lisbet-alvarez
Merge branch 'main' of https://github.com/hashicorp/boundary-ui into …
9ceb1a8 
…ICU-5651-create-spk-type
@lisbet-alvarez
Merge branch 'main' of https://github.com/hashicorp/boundary-ui into …
3e8f5a1 
…ICU-5651-create-spk-type
@lisbet-alvarez
feat: 🎸 Create spk credential type
9b67d78 
Add functionality for creating a ssh private key credential and add
corresponding acceptance tests.

✅ Closes: ICU-5651
@lisbet-alvarez lisbet-alvarez requested a review from a team as a code owner August 17, 2022 23:56
@vercel
Copy link

vercel bot commented Aug 17, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
boundary-ui ✅ Ready (Inspect) Visit Preview Aug 23, 2022 at 8:32PM (UTC)
boundary-ui-desktop ✅ Ready (Inspect) Visit Preview Aug 23, 2022 at 8:32PM (UTC)
boundary-ui-storybook ✅ Ready (Inspect) Visit Preview Aug 23, 2022 at 8:32PM (UTC)

cameronperera
cameronperera approved these changes Aug 18, 2022
View reviewed changes
Copy link
Collaborator

@cameronperera cameronperera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ZedLi
ZedLi requested changes Aug 18, 2022
View reviewed changes
Copy link
Collaborator

@ZedLi ZedLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a few things that I know was present/copied from elsewhere but I think should be cleaned up as we're adding new code.

I commented on some things for one form but it should be applied for both forms.

ui/admin/app/components/form/credential/ssh_private_key/index.hbs Outdated Show resolved Hide resolved
ui/admin/app/components/form/credential/ssh_private_key/index.hbs Outdated Show resolved Hide resolved
ui/admin/app/components/form/credential/ssh_private_key/index.hbs Outdated Show resolved Hide resolved
ui/admin/app/components/form/credential/ssh_private_key/index.hbs Outdated Show resolved Hide resolved
ui/admin/app/components/form/credential/ssh_private_key/index.hbs Outdated Show resolved Hide resolved
ui/admin/app/components/form/credential/ssh_private_key/index.hbs Outdated Show resolved Hide resolved
ui/admin/app/components/form/credential/ssh_private_key/index.hbs Outdated Show resolved Hide resolved
ui/admin/app/routes/scopes/scope/credential-stores/credential-store/credentials/new.js Show resolved Hide resolved
@cameronperera
Copy link
Collaborator

There's a few things that I know was present/copied from elsewhere but I think should be cleaned up as we're adding new code.

I commented on some things for one form but it should be applied for both forms.

Great catch @ZedLi. I didn't realize some of these properties were outdated. Thanks!

ZedLi
ZedLi approved these changes Aug 18, 2022
View reviewed changes
Copy link
Collaborator

@ZedLi ZedLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ZedLi
ZedLi approved these changes Aug 23, 2022
View reviewed changes
addons/api/addon/serializers/credential.js Outdated Show resolved Hide resolved
addons/api/addon/serializers/credential.js Outdated Show resolved Hide resolved
@lisbet-alvarez lisbet-alvarez requested a review from a user August 23, 2022 20:30
DhariniJeeva
DhariniJeeva approved these changes Aug 24, 2022
View reviewed changes
Copy link
Collaborator

@DhariniJeeva DhariniJeeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lisbet-alvarez lisbet-alvarez merged commit fb981c0 into main Aug 24, 2022
@lisbet-alvarez lisbet-alvarez deleted the ICU-5651-create-spk-type branch August 24, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZedLi ZedLi ZedLi approved these changes

@cameronperera cameronperera cameronperera approved these changes

@DhariniJeeva DhariniJeeva DhariniJeeva approved these changes

Assignees
No one assigned
Labels
addons admin api-addon ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lisbet-alvarez @cameronperera @ZedLi @DhariniJeeva