Fix Users page not updating fields correctly #1105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Closes: ICU-4189
✅ Closes: ICU-4189
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ghost
approved these changes
May 11, 2022
| @@ -40,7 +40,7 @@ export default class UserModel extends GeneratedUserModel { | |||
| * There are many options, so we fallback in order of precedence. | |||
| * @type {string} | |||
| */ | |||
| @computed('email,full_name,login_name,displayName') | |||
| @computed('email', 'full_name', 'login_name') | |||
There was a problem hiding this comment.
This computed decorator may not be required at all in Ember Octane: https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/no-computed-properties-in-native-classes.md
It should automagically work the same if the decorator is removed thanks to tracked properties (model attributes are automatically tracked).
…ICU-4189-boundary-ui-iss-1096-admin-ui-users-page-serves-stale-content-after-user-account-association
ZedLi
deleted the
ICU-4189-boundary-ui-iss-1096-admin-ui-users-page-serves-stale-content-after-user-account-association
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Jira ticket
Description
You'll have to run a local boundary dev to test this as you won't see the difference with just mirage data
Screenshots (if appropriate):
Taken from the ticket:
https://user-images.githubusercontent.com/6604151/166251178-fea3b1e4-bcbc-4c40-ab90-8a9d5c46da01.mov
After:
