disable service account validation on DisableCredentialRotation

[kheina]

this should allow the plugin to work with other S3-compatible providers by using DisableCredentialRotation=true

[louisruch]

Mostly looks good, I have one question on where we are doing the service account check

[louisruch]

Is this true? If it is the first time we are rotating credentials and its not a service account wont the rotation fail? My understanding was we cannot rotate if its not a service account, does this change then make it so we fail to rotate instead of validating the service account and fail on that? If that is the case is this check then just redundant?

[kheina]

the first thing the rotation func does is run ensure service account, so that's done already:

boundary-plugin-minio/plugin/service/storage/rotation.go

Lines 52 to 56 in 07cb856

	func rotateCredentials(ctx context.Context, bucketName string, sa *StorageAttributes, inSec *StorageSecrets) (*StorageSecrets, deleteInputCredsFn, error) {
	err := ensureServiceAccount(ctx, sa, inSec)
	if err != nil {
	return nil, nil, fmt.Errorf("failed to ensure minio service account credentials: %w", err)
	}