feat: support dual stack requests for aws clients #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kheina
reviewed
Oct 16, 2024
elimt
reviewed
Oct 16, 2024
elimt
approved these changes
Oct 17, 2024
louisruch
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Great work sorry for taking so long to review. I left one minor comment. Otherwise we have been using the readme's in the services as a source of truth for valid attribute and secret fields in conversations recently. We should therefore add dual_stack to those two readmes until we have a better option for documenting this.
ddebko
force-pushed
the
ddebko-ipv6-compatability
branch
2 times, most recently
from
1c9d6f1 to
8ab07c3
Compare
ddebko
force-pushed
the
ddebko-ipv6-compatability
branch
from
8ab07c3 to
97aae6e
Compare
louisruch
added a commit
that referenced
this pull request
Dec 10, 2024
This reverts commit 899c62c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Dual stack access for ipv4/ipv6 is by default disabled in aws clients. This PR allows users to enable dual stack access using the attributes field. The new field
dual_stackis a boolean type.Concerns
Updating the aws dependencies have caused the memory usage in boundary to spike. Before updating the aws dependencies, boundary was utilizing ~460MB while idling. With the updates, boundary is utilizing ~720MB while idling. I think this is concerning, but I'm not sure how to proceed.