Skip to content

Commit

Permalink
fixup! feat(service): Add support for host plugin AssumeRole
Browse files Browse the repository at this point in the history
  • Loading branch information
hugoghx committed Sep 18, 2024
1 parent e6a35ac commit 247146f
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions plugin/service/host/plugin.go
Original file line number Diff line number Diff line change
Expand Up @@ -669,9 +669,10 @@ func awsInstanceToHost(instance types.Instance) (*pb.ListHostsResponseHost, erro
return result, nil
}

// dryRunValidation validates that the IAM role policy attached to the given secrets of the
// storage bucket has the minimum required permissions needed for this plugin to function
// as expected. This function will attempt to list AWS hosts.
// dryRunValidation performs an AWS DescribeInstances call to verify the state's
// credentials, the host listing functionality as well as the filters, if any
// are passed in. This function can therefore be used for both host catalog and
// host set validation.
func dryRunValidation(ctx context.Context, state *awsCatalogPersistedState, filters ...types.Filter) *status.Status {
if state == nil {
return status.New(codes.InvalidArgument, "persisted state is required")
Expand Down

0 comments on commit 247146f

Please sign in to comment.