Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new AWS region, ap-southeast-4 #348

Merged
merged 3 commits into from
Feb 6, 2023
Merged

Add new AWS region, ap-southeast-4 #348

merged 3 commits into from
Feb 6, 2023

Conversation

oliverjfletcher
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #347

@oliverjfletcher oliverjfletcher requested a review from a team as a code owner February 6, 2023 11:32
@hashicorp-cla
Copy link

hashicorp-cla commented Feb 6, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

ewbankkit
ewbankkit previously approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@oliverjfletcher Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit 1413419 into hashicorp:main Feb 6, 2023
@oliverjfletcher oliverjfletcher deleted the feat/ap-southeast-4-endpoint branch February 6, 2023 21:57
ewbankkit added a commit that referenced this pull request Feb 7, 2023
@ewbankkit
Update CHANGELOG for #348.
cec845a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new ap-southeast-4 AWS Region to internal/endpoints/endpoints.go
3 participants
@oliverjfletcher @hashicorp-cla @ewbankkit