Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimal updates to get working end-to-end #4

Closed
wants to merge 1 commit into from
Closed

Conversation

tgross
Copy link
Contributor

@tgross tgross commented Apr 29, 2024

After testing in a fresh environment, I found a number of steps that don't work, are out of order, or have undesireable effects. This changeset represents a minimum amount of updates just to get this all working without improving the workflow more generally.

This includes:

  • Bootstrap Consul ACLs after configuring the Consul environment variables, so that we can connect to the Consul agent we're trying to configure.
  • Run nomad with the -dev-connect flag so that the API GW is listening on a non-localhost address.
  • Make it clear the certs used for the Nomad CLI are the ones named "server".
  • Update the Docker build step so that in the default local development case we're building an image that Nomad will not try to download.
  • Add the missing Consul gRPC and HTTP address to the values we write to Nomad Variables, and make the name of the Consul CA variable consistent with Consul's use.
  • Explain where to find the API GW address and port.
  • Remove incorrect references to env vars from the Nomad agent config.
  • Make the tls.cert_file and tls.key_file path match the names of the files we create.
  • Ensure we don't commit certificates by adding them to .gitignore

Additional PRs will follow on this repo to deal with #2 and #3.

After testing in a fresh environment, I found a number of steps that don't work,
are out of order, or have undesireable effects. This changeset represents a
minimum amount of updates just to get this all working without improving the
workflow more generally.

This includes:
* Bootstrap Consul ACLs after configuring the Consul environment variables, so
  that we can connect to the Consul agent we're trying to configure.
* Run `nomad` with the `-dev-connect` flag so that the API GW is listening on a
  non-localhost address.
* Make it clear the certs used for the Nomad CLI are the ones named "server".
* Update the Docker build step so that in the default local development case
  we're building an image that Nomad will not try to download.
* Add the missing Consul gRPC and HTTP address to the values we write to Nomad
  Variables, and make the name of the Consul CA variable consistent with
  Consul's use.
* Explain where to find the API GW address and port.
* Remove incorrect references to env vars from the Nomad agent config.
* Make the `tls.cert_file` and `tls.key_file` path match the names of the files
  we create.
* Ensure we don't commit certificates by adding them to `.gitignore`

Additional PRs will follow on this repo to resolve #2 and #3.
@tgross
Copy link
Contributor Author

tgross commented May 7, 2024

Closing in lieu of #5

@tgross tgross closed this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant