Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: local chart directory not being taken correctly #983

Merged
merged 12 commits into from
Dec 12, 2024

Avoid failing on windows due to different separator

300a600
Select commit
Loading
Failed to load commit list.
Merged

fix: local chart directory not being taken correctly #983

Avoid failing on windows due to different separator
300a600
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 12, 2024 in 0s

85.04% (+2.30%) compared to d6b823a

View this Pull Request on Codecov

85.04% (+2.30%) compared to d6b823a

Details

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.04%. Comparing base (d6b823a) to head (300a600).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/commands/network.ts 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #983      +/-   ##
==========================================
+ Coverage   82.73%   85.04%   +2.30%     
==========================================
  Files          71       71              
  Lines       19139    19133       -6     
  Branches     1294     1443     +149     
==========================================
+ Hits        15835    16271     +436     
+ Misses       3253     2810     -443     
- Partials       51       52       +1     
Files with missing lines Coverage Δ
src/commands/base.ts 95.21% <100.00%> (+0.02%) ⬆️
src/commands/cluster.ts 67.34% <100.00%> (+0.68%) ⬆️
src/commands/node/configs.ts 96.96% <100.00%> (+9.31%) ⬆️
src/commands/node/tasks.ts 94.20% <100.00%> (+11.50%) ⬆️
src/core/constants.ts 97.00% <100.00%> (-0.02%) ⬇️
src/commands/network.ts 72.05% <75.00%> (+0.91%) ⬆️

... and 18 files with indirect coverage changes

Impacted file tree graph