Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inconsistent failures #866

Merged
merged 14 commits into from
Nov 25, 2024

remove node-add from workflows

7f7e4a8
Select commit
Loading
Failed to load commit list.
Merged

fix: inconsistent failures #866

remove node-add from workflows
7f7e4a8
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 25, 2024 in 1s

83.82% (-3.28%) compared to b66fe05

View this Pull Request on Codecov

83.82% (-3.28%) compared to b66fe05

Details

Codecov Report

Attention: Patch coverage is 89.02821% with 35 lines in your changes missing coverage. Please review.

Project coverage is 83.82%. Comparing base (b66fe05) to head (7f7e4a8).
Report is 82 commits behind head on main.

Files with missing lines Patch % Lines
src/commands/node/tasks.ts 88.16% 20 Missing ⚠️
src/core/k8.ts 88.23% 10 Missing ⚠️
src/commands/node/handlers.ts 70.00% 3 Missing ⚠️
src/core/helpers.ts 75.00% 1 Missing ⚠️
src/core/logging.ts 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #866      +/-   ##
==========================================
- Coverage   87.09%   83.82%   -3.28%     
==========================================
  Files          40       49       +9     
  Lines       12545    14769    +2224     
  Branches      944     1029      +85     
==========================================
+ Hits        10926    12380    +1454     
- Misses       1568     2370     +802     
+ Partials       51       19      -32     
Files with missing lines Coverage Δ
src/commands/flags.ts 99.56% <100.00%> (+0.06%) ⬆️
src/commands/network.ts 75.73% <100.00%> (-0.69%) ⬇️
src/commands/node/configs.ts 88.34% <100.00%> (-7.11%) ⬇️
src/commands/node/flags.ts 100.00% <100.00%> (ø)
src/core/account_manager.ts 85.24% <100.00%> (+0.74%) ⬆️
src/core/config_manager.ts 93.03% <100.00%> (+0.27%) ⬆️
src/core/constants.ts 96.72% <100.00%> (+0.56%) ⬆️
src/core/enumerations.ts 100.00% <100.00%> (ø)
src/core/platform_installer.ts 89.59% <100.00%> (+0.38%) ⬆️
src/core/helpers.ts 80.52% <75.00%> (-10.81%) ⬇️
... and 4 more

... and 16 files with indirect coverage changes

Impacted file tree graph

---- 🚨 Try these New Features: