Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add tests for file update related to system files #1086

Merged
merged 8 commits into from
Oct 31, 2024

Conversation

yiliev0
Copy link
Contributor

@yiliev0 yiliev0 commented Oct 25, 2024

Description: These tests cover updating system files(101, 102, 111, 112, 121, 122, 123)

Related issue(s):

Fixes #381

Notes for reviewer: Test might need to be updated once SDK fix is applied

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copy link

codecov bot commented Oct 25, 2024

The author of this PR, yiliev0, is not an activated member of this organization on Codecov.
Please activate this user on Codecov to display this PR comment.
Coverage data is still being uploaded to Codecov.io for purposes of overall coverage calculations.
Please don't hesitate to email us at [email protected] with any questions.

@yiliev0 yiliev0 requested review from a team as code owners October 25, 2024 13:18
@yiliev0 yiliev0 marked this pull request as draft October 25, 2024 13:52
@yiliev0
Copy link
Contributor Author

yiliev0 commented Oct 25, 2024

The tests need to be updated to include additional verification by reading the file using a file read query.

@yiliev0 yiliev0 force-pushed the 381-add-tests-for-file-update branch from 766cbd1 to 2827788 Compare October 29, 2024 07:16
@yiliev0 yiliev0 force-pushed the 381-add-tests-for-file-update branch from 572dd27 to 932986d Compare October 31, 2024 10:50
@yiliev0 yiliev0 marked this pull request as ready for review October 31, 2024 10:50
@yiliev0 yiliev0 merged commit b5856df into main Oct 31, 2024
9 of 12 checks passed
@yiliev0 yiliev0 deleted the 381-add-tests-for-file-update branch October 31, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test cases for testing the multisig/organization transaction flow
2 participants