Make handoff to record-stream thread w/ ArrayBlockingQueue#offer not LinkedBlockingQueue#put #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tinker-michaelj <[email protected]>
…g user transaction Signed-off-by: tinker-michaelj <[email protected]>
Signed-off-by: tinker-michaelj <[email protected]>
Signed-off-by: tinker-michaelj <[email protected]>
Signed-off-by: tinker-michaelj <[email protected]>
…cessLogic change Signed-off-by: tinker-michaelj <[email protected]>
Signed-off-by: tinker-michaelj <[email protected]>
Signed-off-by: tinker-michaelj <[email protected]>
Signed-off-by: tinker-michaelj <[email protected]>
Signed-off-by: tinker-michaelj <[email protected]>
…isable CI for now Signed-off-by: tinker-michaelj <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: tinker-michaelj <[email protected]>
Signed-off-by: tinker-michaelj <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: tinker-michaelj <[email protected]>
Signed-off-by: tinker-michaelj <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: tinker-michaelj <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
Signed-off-by: Neeharika-Sompalli <[email protected]>
added 19 commits
May 30, 2021 11:34
…edSubmitKey() Signed-off-by: tinker-michaelj <[email protected]>
Signed-off-by: tinker-michaelj <[email protected]>
…ueueCapacity=5000 Signed-off-by: tinker-michaelj <[email protected]>
Signed-off-by: tinker-michaelj <[email protected]>
Signed-off-by: tinker-michaelj <[email protected]>
Signed-off-by: tinker-michaelj <[email protected]>
Signed-off-by: tinker-michaelj <[email protected]>
Signed-off-by: tinker-michaelj <[email protected]>
…ndoffTest Signed-off-by: tinker-michaelj <[email protected]>
…into 01499-01498-ExpandPtaInitFields
Signed-off-by: tinker-michaelj <[email protected]>
Signed-off-by: tinker-michaelj <[email protected]>
Signed-off-by: tinker-michaelj <[email protected]>
…eNonBlockingHandoff
Signed-off-by: tinker-michaelj <[email protected]>
…into 01500-M0150-CreateNonBlockingHandoff
Signed-off-by: tinker-michaelj <[email protected]>
Signed-off-by: tinker-michaelj <[email protected]>
…00-M0150-CreateNonBlockingHandoff
Codecov Report
@@ Coverage Diff @@
## master-plus-sdk-0.15.0 #1547 +/- ##
=========================================================
Coverage 91.53% 91.53%
- Complexity 5880 5892 +12
=========================================================
Files 462 463 +1
Lines 17014 17044 +30
Branches 1778 1780 +2
=========================================================
+ Hits 15574 15602 +28
Misses 986 986
- Partials 454 456 +2
Continue to review full report at Codecov.
|
tinker-michaelj
requested review from
abhishek-hedera,
anighanta,
ljianghedera,
qnswirlds and
Neeharika-Sompalli
qnswirlds
reviewed
Jun 7, 2021
| //setup: | ||
| // setup: | ||
| nonBlockingHandoff = mock(NonBlockingHandoff.class); | ||
| given(nonBlockingHandoff.offer(any())).willReturn(true); |
There was a problem hiding this comment.
Should test with returning false a few times before returning true.
| @@ -59,6 +59,7 @@ | |||
| import static org.hamcrest.collection.IsIterableContainingInOrder.contains; | |||
| import static org.junit.jupiter.api.Assertions.assertFalse; | |||
| import static org.junit.jupiter.api.Assertions.assertTrue; | |||
| import static org.mockito.ArgumentMatchers.eq; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sonar passed w/ no (actual) new code smells here.
Related issue(s):
Closes #1500
Summary of the change:
NonBlockingHandoffthat effectively puts anArrayBlockingQueuebetween thehandleTransactionthread and therecordStreamthread.handleTransactionfrom blocking on theLinkedBlockingQueue#putused by theRecordStreamManagerthreads, which from profiling appears almost 200% slower thanArrayBlockingQueue#offer.Note: This PR also adds a
memofield to theTxnAccessorto eliminate a curiously expensive call to the gRPCTransactionBody.getMemo()method.