01399 m yacli valide ip and port address book update #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g an addressBook using yahcli Signed-off-by: anighanta <[email protected]>
Signed-off-by: anighanta <[email protected]>
Signed-off-by: anighanta <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1454 +/- ##
=========================================
Coverage 88.90% 88.90%
Complexity 5854 5854
=========================================
Files 460 460
Lines 17311 17311
Branches 1810 1810
=========================================
Hits 15390 15390
Misses 1457 1457
Partials 464 464 Continue to review full report at Codecov.
|
Signed-off-by: anighanta <[email protected]>
ljianghedera
pushed a commit
that referenced
this pull request
May 25, 2021
* add checks to validate port number in service endpoints when uploading an addressBook using yahcli Signed-off-by: anighanta <[email protected]> * add test addressbook for bad port in endpoint Signed-off-by: anighanta <[email protected]> * updated gitignore to not track script files from yahcli/assests Signed-off-by: anighanta <[email protected]> * screened launch script Signed-off-by: anighanta <[email protected]>
ljianghedera
added a commit
that referenced
this pull request
May 26, 2021
* Replace RichInstant with Instant in MerkleNetworkContext, hence reduce the conversion between these two types. * Add MerkleNetworkContext.deserialize() null-safety and avoid transient ISS (#1464) * Add null-safety and avoid transient ISS from MerkleNetworkContext fast-copy sharing FeeMultiplierSource congestionLevelStarts Signed-off-by: tinker-michaelj <[email protected]> * Fix unit test Signed-off-by: tinker-michaelj <[email protected]> * 01399 m yacli valide ip and port address book update (#1454) * add checks to validate port number in service endpoints when uploading an addressBook using yahcli Signed-off-by: anighanta <[email protected]> * add test addressbook for bad port in endpoint Signed-off-by: anighanta <[email protected]> * updated gitignore to not track script files from yahcli/assests Signed-off-by: anighanta <[email protected]> * screened launch script Signed-off-by: anighanta <[email protected]> * Resolve SonarCloud Minor Bugs (#1449) * fix few minor sonarcloud bugs Signed-off-by: Neeharika-Sompalli <[email protected]> * Additional fixes Signed-off-by: Neeharika-Sompalli <[email protected]> * fix code smell Signed-off-by: Neeharika-Sompalli <[email protected]> * move duplicated code to a method Signed-off-by: Neeharika-Sompalli <[email protected]> * fix other minor bugs Signed-off-by: Neeharika-Sompalli <[email protected]> * fix other issues Signed-off-by: Neeharika-Sompalli <[email protected]> * remove unnecessary toString() calls Signed-off-by: Neeharika-Sompalli <[email protected]> * add braces Signed-off-by: Neeharika-Sompalli <[email protected]> * remove a few casts Signed-off-by: Neeharika-Sompalli <[email protected]> * convert getCommonTransactionBodyBytes and legacyReceiptStorageSecs to return long and remove casts Signed-off-by: Neeharika-Sompalli <[email protected]> * fix other bugs created Signed-off-by: Neeharika-Sompalli <[email protected]> * Address review comments and fix alignment in SmartContractFeeBuilder Signed-off-by: Neeharika-Sompalli <[email protected]> * address few review comments Signed-off-by: Neeharika-Sompalli <[email protected]> * fix few other review points Signed-off-by: Neeharika-Sompalli <[email protected]> * fix typo Signed-off-by: Neeharika-Sompalli <[email protected]> * fix review comments, add UnitTest for MerkleDiskFs Signed-off-by: Neeharika-Sompalli <[email protected]> * Add unit tests for FreezeHandler Signed-off-by: Neeharika-Sompalli <[email protected]> * fix random failing tests because of MockedStatic Signed-off-by: Neeharika-Sompalli <[email protected]> * add more tests for codecov Signed-off-by: Neeharika-Sompalli <[email protected]> * fix all failing tests, yet to add more tests for code coverage Signed-off-by: Neeharika-Sompalli <[email protected]> * remove main method in SignatureVerifier and unused methods as they are not used anywhere Signed-off-by: Neeharika-Sompalli <[email protected]> * Address other review comments Signed-off-by: Neeharika-Sompalli <[email protected]> * Fix blocker and critical sonar bugs. (#1446) Signed-off-by: ljianghedera <[email protected]> * Fix the json map issue. Signed-off-by: ljianghedera <[email protected]> * Rename and changes per review comments. Signed-off-by: ljianghedera <[email protected]> * Cleanup and more coverage. Signed-off-by: ljianghedera <[email protected]> Co-authored-by: Michael Tinker <[email protected]> Co-authored-by: Anirudh Ghanta <[email protected]> Co-authored-by: Neeha <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the change:
update gitignore . related to PR merge - #1412