Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(TCK): Implement JSON-RPC endpoint for AccountDeleteTransaction #409

Merged
merged 1 commit into from
Nov 13, 2024
Merged

feat(TCK): Implement JSON-RPC endpoint for AccountDeleteTransaction #409

merged 1 commit into from
Nov 13, 2024

Conversation

rwalworth
Copy link
Contributor

Description:
This PR adds the JSON-RPC deleteAccount to service AccountDeleteTransaction TCK tests.

Related issue(s):

Fixes #404

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@rwalworth rwalworth added the enhancement New feature or request label Nov 12, 2024
@rwalworth rwalworth self-assigned this Nov 12, 2024
@rwalworth rwalworth requested review from a team as code owners November 12, 2024 23:09
@rwalworth rwalworth linked an issue Nov 12, 2024 that may be closed by this pull request
TCK-Swift: Implement AccountDeleteTransation JSON-RPC method endpoint #404
Closed
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 12, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

RickyLB
RickyLB approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@RickyLB RickyLB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RickyLB RickyLB merged commit adf08f1 into main Nov 13, 2024
15 checks passed
@RickyLB RickyLB deleted the 00404-tck-swift-implement-accountdeletetransation-json-rpc-method-endpoint branch November 13, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RickyLB RickyLB RickyLB approved these changes

Assignees

@rwalworth rwalworth

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TCK-Swift: Implement AccountDeleteTransation JSON-RPC method endpoint
2 participants
@rwalworth @RickyLB