Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding account 32, 33, and 34 endpoints to the clientconstants.js #2607

Merged

Conversation

rustyShacklefurd
Copy link
Contributor

Description:
This PR adds accounts 32, 33, and 34 to the ClientConstants.js library

Related issue(s):
infrastructure/issues/6377

Notes for reviewer:
Each of the URLs provided here is available via dig and nslookup

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copy link

sonarcloud bot commented Oct 24, 2024

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.71%. Comparing base (e9bf5c3) to head (e91d9c7).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2607   +/-   ##
=======================================
  Coverage   84.71%   84.71%           
=======================================
  Files         283      283           
  Lines       71086    71089    +3     
=======================================
+ Hits        60218    60221    +3     
  Misses      10868    10868           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rwalworth rwalworth added this to the v2.54.0 milestone Oct 29, 2024
Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty @matteriben

@agadzhalov agadzhalov changed the title adding account 32, 33, and 34 endpoints to the clientconstants.js chore: adding account 32, 33, and 34 endpoints to the clientconstants.js Oct 30, 2024
@agadzhalov agadzhalov merged commit 0c02eca into hashgraph:main Oct 30, 2024
13 checks passed
@agadzhalov agadzhalov modified the milestones: v2.54.0, v2.53.0 Oct 30, 2024
This was referenced Oct 30, 2024
@ivaylonikolov7 ivaylonikolov7 mentioned this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants