Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix vulnerable library versions #2594

Merged
merged 11 commits into from
Oct 28, 2024
Merged

Conversation

mishomihov00
Copy link
Contributor

@mishomihov00 mishomihov00 commented Oct 18, 2024

Description:

Changed some library versions, according to the recommendations from Snyk.

Related issue(s):

Related to #1645

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@mishomihov00 mishomihov00 linked an issue Oct 18, 2024 that may be closed by this pull request
@mishomihov00 mishomihov00 self-assigned this Oct 18, 2024
@mishomihov00 mishomihov00 added this to the v2.53.0 milestone Oct 18, 2024
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.46%. Comparing base (3408441) to head (57eac47).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2594   +/-   ##
=======================================
  Coverage   84.45%   84.46%           
=======================================
  Files         283      283           
  Lines       71088    71088           
=======================================
+ Hits        60037    60044    +7     
+ Misses      11051    11044    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mishomihov00 mishomihov00 marked this pull request as ready for review October 22, 2024 12:15
@mishomihov00 mishomihov00 requested review from a team as code owners October 22, 2024 12:15
@agadzhalov
Copy link
Contributor

I am a bit reserved on the upgrading of the Expo version overall the CI checks are passing @ivaylonikolov7 had some issues with this and we've postponed it. @mishomihov00 you can follow the discussion in here

Copy link

sonarcloud bot commented Oct 23, 2024

@mishomihov00
Copy link
Contributor Author

@agadzhalov I've downgraded the version back to 49.0.16

@mishomihov00
Copy link
Contributor Author

@agadzhalov Can you please take a look at this PR and approve if everything seems ok. Thansk!

Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty @mishomihov00

Copy link
Contributor

@ivaylogarnev-limechain ivaylogarnev-limechain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mishomihov00 mishomihov00 merged commit cf51a5a into main Oct 28, 2024
13 checks passed
@mishomihov00 mishomihov00 deleted the 1645-review-snyk-report branch October 28, 2024 07:02
@mishomihov00 mishomihov00 mentioned this pull request Oct 28, 2024
This was referenced Oct 30, 2024
@ivaylonikolov7 ivaylonikolov7 mentioned this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review Snyk Report
4 participants