fix: serialize deserialize FileAppend #2532

ivaylonikolov7 · 2024-09-18T21:04:21Z

Description:
Implement chunk logic for toBytes method and disallow addSignature function until the next release.

Notes for reviewer:
There should be refactoring done. We need to implement ChunkTransaction. This fix is more like a patch before the major refactor for ChunkedTransaction like the other SDKs.

Checklist

Documented (Code comments, README, etc.)
Tested (unit, integration, etc.)

codecov · 2024-09-19T20:18:44Z

Codecov Report

Attention: Patch coverage is 82.05128% with 21 lines in your changes missing coverage. Please review.

Project coverage is 84.39%. Comparing base (8bf5b24) to head (a4fa3a7).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/file/FileAppendTransaction.js	77.89%	21 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2532   +/-   ##
=======================================
  Coverage   84.39%   84.39%           
=======================================
  Files         283      283           
  Lines       70929    71017   +88     
=======================================
+ Hits        59863    59938   +75     
- Misses      11066    11079   +13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ivaylo Nikolov <[email protected]>

…nsaction class Signed-off-by: Ivaylo Nikolov <[email protected]>

Signed-off-by: Ivaylo Nikolov <[email protected]>

src/file/FileAppendTransaction.js

test/integration/FileAppendIntegrationTest.js

Signed-off-by: Ivaylo Nikolov <[email protected]>

0xivanov

LGTM

test/integration/FileAppendIntegrationTest.js

src/file/FileAppendTransaction.js

test/integration/FileAppendIntegrationTest.js

src/file/FileAppendTransaction.js

src/transaction/Transaction.js

Signed-off-by: Ivaylo Nikolov <[email protected]>

agadzhalov

LGTM

sonarcloud · 2024-10-04T14:09:00Z

Quality Gate failed

Failed conditions
13.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

* fix: serialize deserialize fileappend Signed-off-by: Ivaylo Nikolov <[email protected]> * fix: return _makeTransactionData Signed-off-by: Ivaylo Nikolov <[email protected]> * test: add integration test for fromByte toByte converison Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: implement better transaction conversion Signed-off-by: Ivaylo Nikolov <[email protected]> * fix: fileappend hip-765 finish implementation Signed-off-by: Ivaylo Nikolov <[email protected]> * revert: remove multi signature multi node feat for FileAppend Signed-off-by: Ivaylo Nikolov <[email protected]> * test: freeze transaction after fromBytes Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: disallow addSignature check for chunked transactions in transaction class Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: linter complains about skipped test Signed-off-by: Ivaylo Nikolov <[email protected]> * fix: move type definitions because of linter Signed-off-by: Ivaylo Nikolov <[email protected]> * revert: old type definitions Signed-off-by: Ivaylo Nikolov <[email protected]> * fix: throw error when required chunks are more than max chunks Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: required chunks should not be an error Signed-off-by: Ivaylo Nikolov <[email protected]> * style: fix jsdoc comment when building incomplete transaction Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: reuse variables in file append integration tests Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: delete already defined variables Signed-off-by: Ivaylo Nikolov <[email protected]> * test: fix typo in test name Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: return back addSignature return type Signed-off-by: Ivaylo Nikolov <[email protected]> * test: fix typo Signed-off-by: Ivaylo Nikolov <[email protected]> * fix: implement maxChunks when serializing content too Signed-off-by: Ivaylo Nikolov <[email protected]> * fix: wrong comparison Signed-off-by: Ivaylo Nikolov <[email protected]> * style: add empty lines Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: generate new transactionId Signed-off-by: Ivaylo Nikolov <[email protected]> * test: add more integration tests Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: extract dummy account id to const Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: fix function nane typo Signed-off-by: Ivaylo Nikolov <[email protected]> * refactor: fix function name typo 2 Signed-off-by: Ivaylo Nikolov <[email protected]> * chore: remove incompleted references Signed-off-by: Ivaylo Nikolov <[email protected]> --------- Signed-off-by: Ivaylo Nikolov <[email protected]> Signed-off-by: b-l-u-e <[email protected]>

ivaylonikolov7 marked this pull request as ready for review September 19, 2024 14:24

ivaylonikolov7 requested review from a team as code owners September 19, 2024 14:24

ivaylonikolov7 requested review from rwalworth and gsstoykov September 19, 2024 14:24

ivaylonikolov7 added 4 commits September 23, 2024 20:08

fix: serialize deserialize fileappend

d7b959e

Signed-off-by: Ivaylo Nikolov <[email protected]>

fix: return _makeTransactionData

0f78be6

Signed-off-by: Ivaylo Nikolov <[email protected]>

test: add integration test for fromByte toByte converison

a313cbd

Signed-off-by: Ivaylo Nikolov <[email protected]>

refactor: implement better transaction conversion

bf96864

Signed-off-by: Ivaylo Nikolov <[email protected]>

ivaylonikolov7 force-pushed the feat/serialize-deserialize-tx branch from efdc396 to 40f799a Compare September 25, 2024 20:37

ivaylonikolov7 added 3 commits September 25, 2024 23:38

fix: fileappend hip-765 finish implementation

4a2336f

Signed-off-by: Ivaylo Nikolov <[email protected]>

revert: remove multi signature multi node feat for FileAppend

fda7698

Signed-off-by: Ivaylo Nikolov <[email protected]>

test: freeze transaction after fromBytes

16a476d

Signed-off-by: Ivaylo Nikolov <[email protected]>

ivaylonikolov7 force-pushed the feat/serialize-deserialize-tx branch from 40f799a to 16a476d Compare September 25, 2024 20:42

ivaylonikolov7 added 4 commits September 26, 2024 00:03

refactor: disallow addSignature check for chunked transactions in tra…

1fe2757

…nsaction class Signed-off-by: Ivaylo Nikolov <[email protected]>

refactor: linter complains about skipped test

a33723c

Signed-off-by: Ivaylo Nikolov <[email protected]>

fix: move type definitions because of linter

2599b05

Signed-off-by: Ivaylo Nikolov <[email protected]>

revert: old type definitions

a000f74

Signed-off-by: Ivaylo Nikolov <[email protected]>

0xivanov reviewed Sep 26, 2024

View reviewed changes

ivaylonikolov7 added 10 commits September 26, 2024 15:52

fix: throw error when required chunks are more than max chunks

a64a9cc

Signed-off-by: Ivaylo Nikolov <[email protected]>

refactor: required chunks should not be an error

4ca93d8

Signed-off-by: Ivaylo Nikolov <[email protected]>

style: fix jsdoc comment when building incomplete transaction

b02bdc6

Signed-off-by: Ivaylo Nikolov <[email protected]>

refactor: reuse variables in file append integration tests

0d6609f

Signed-off-by: Ivaylo Nikolov <[email protected]>

refactor: delete already defined variables

7bf8237

Signed-off-by: Ivaylo Nikolov <[email protected]>

test: fix typo in test name

296e595

Signed-off-by: Ivaylo Nikolov <[email protected]>

refactor: return back addSignature return type

277c401

Signed-off-by: Ivaylo Nikolov <[email protected]>

test: fix typo

96e14ca

Signed-off-by: Ivaylo Nikolov <[email protected]>

fix: implement maxChunks when serializing content too

4cc5e9b

Signed-off-by: Ivaylo Nikolov <[email protected]>

fix: wrong comparison

8dea2d5

Signed-off-by: Ivaylo Nikolov <[email protected]>

0xivanov previously approved these changes Sep 27, 2024

View reviewed changes

ivaylonikolov7 requested a review from ivaylogarnev-limechain September 27, 2024 08:18

gsstoykov reviewed Sep 27, 2024

View reviewed changes

ivaylonikolov7 added 3 commits September 30, 2024 14:34

style: add empty lines

c2312e9

Signed-off-by: Ivaylo Nikolov <[email protected]>

refactor: generate new transactionId

685c6f0

Signed-off-by: Ivaylo Nikolov <[email protected]>

test: add more integration tests

7147b1e

Signed-off-by: Ivaylo Nikolov <[email protected]>

ivaylonikolov7 dismissed 0xivanov’s stale review via 7147b1e September 30, 2024 11:37

ivaylonikolov7 added 4 commits September 30, 2024 14:46

refactor: extract dummy account id to const

9913af4

Signed-off-by: Ivaylo Nikolov <[email protected]>

refactor: fix function nane typo

3783646

Signed-off-by: Ivaylo Nikolov <[email protected]>

refactor: fix function name typo 2

16ea79e

Signed-off-by: Ivaylo Nikolov <[email protected]>

chore: remove incompleted references

58ec24d

Signed-off-by: Ivaylo Nikolov <[email protected]>

gsstoykov approved these changes Sep 30, 2024

View reviewed changes

agadzhalov approved these changes Oct 4, 2024

View reviewed changes

Merge branch 'main' into feat/serialize-deserialize-tx

a4fa3a7

ivaylonikolov7 merged commit 596d115 into main Oct 4, 2024
11 of 13 checks passed

ivaylonikolov7 deleted the feat/serialize-deserialize-tx branch October 4, 2024 15:00

agadzhalov mentioned this pull request Oct 4, 2024

FileAppend serialize and deserialize breaks freezing #2536

Closed

This was referenced Oct 7, 2024

release: v2.52.0-beta.2 #2563

Merged

release: v2.52.0-beta.3 #2564

Merged

hedera-eng-infrastructure mentioned this pull request Nov 7, 2024

[Snyk] Upgrade @hashgraph/sdk from 2.50.0 to 2.52.0 hashgraph/hedera-transaction-tool#1127

Closed

swirlds-automation mentioned this pull request Nov 7, 2024

build(deps): [Snyk] Upgrade @hashgraph/sdk from 2.51.0 to 2.52.0 hashgraph/hedera-json-rpc-relay#3230

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: serialize deserialize FileAppend #2532

fix: serialize deserialize FileAppend #2532

ivaylonikolov7 commented Sep 18, 2024 •

edited

Loading

codecov bot commented Sep 19, 2024 •

edited

Loading

0xivanov left a comment

agadzhalov left a comment

sonarcloud bot commented Oct 4, 2024

fix: serialize deserialize FileAppend #2532

fix: serialize deserialize FileAppend #2532

Conversation

ivaylonikolov7 commented Sep 18, 2024 • edited Loading

codecov bot commented Sep 19, 2024 • edited Loading

Codecov Report

0xivanov left a comment

Choose a reason for hiding this comment

agadzhalov left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Oct 4, 2024

Quality Gate failed

ivaylonikolov7 commented Sep 18, 2024 •

edited

Loading

codecov bot commented Sep 19, 2024 •

edited

Loading