fix: React Native's BIP32 implementation should use array instead of Buffer #2502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncompatibility Signed-off-by: Ivaylo Nikolov <[email protected]>
|
ivaylonikolov7
deleted the
feat/cryptography-buffer-issue-in-react-native
branch
Merged
ivaylogarnev-limechain
pushed a commit
that referenced
this pull request
Sep 19, 2024
…ncompatibility (#2502) Signed-off-by: Ivaylo Nikolov <[email protected]> Signed-off-by: ivaylogarnev-limechain <[email protected]>
This was referenced Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We should use Arrays instead of Buffers whenever possible because of React Native's inability to deal with Buffers BIP32. This PR changes
packages/cryptography/src/primitive/Bip32.native.js. There is no need to changepackages/cryptography/src/primitive/BIP32.jsas it is used in different environment. And the web version of this file already uses the correct functions.Related issue(s):
#2458
Fixes #
#2458
Checklist