feat: dynamic address book [HIP-869] #2403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2403 +/- ##
==========================================
+ Coverage 76.49% 84.45% +7.95%
==========================================
Files 304 308 +4
Lines 75800 77354 +1554
==========================================
+ Hits 57986 65330 +7344
+ Misses 17814 12024 -5790 ☔ View full report in Codecov by Sentry. |
svetoslav-nikol0v
requested review from
rwalworth
and removed request for
rwalworth
* feat: add addressBook channel Signed-off-by: svetoslav-nikol0v <[email protected]> * feat: implement NodeCreateTransaction class Signed-off-by: svetoslav-nikol0v <[email protected]> * feat: implement ServiceEndpoint class Signed-off-by: svetoslav-nikol0v <[email protected]> * chore: export new classess Signed-off-by: svetoslav-nikol0v <[email protected]> * update: proto changes Signed-off-by: svetoslav-nikol0v <[email protected]> * update: transaction receipt Signed-off-by: svetoslav-nikol0v <[email protected]> * fix: unit tests Signed-off-by: svetoslav-nikol0v <[email protected]> * fix: method in node create transaction Signed-off-by: svetoslav-nikol0v <[email protected]> --------- Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
* feat: node update transaction Signed-off-by: svetoslav-nikol0v <[email protected]> * fix: adjustments Signed-off-by: svetoslav-nikol0v <[email protected]> --------- Signed-off-by: svetoslav-nikol0v <[email protected]>
* chore: formatting Signed-off-by: Svet <[email protected]> * add: example Signed-off-by: Svet <[email protected]> * chore: formatting Signed-off-by: Svet <[email protected]> * update: example Signed-off-by: Svet <[email protected]> --------- Signed-off-by: Svet <[email protected]>
svetoslav-nikol0v
force-pushed
the
hip-869-dynamic-address-book
branch
from
056f10f
to
516b7f3
Compare
Signed-off-by: Svet <[email protected]>
|
0xivanov
reviewed
Aug 8, 2024
0xivanov
reviewed
Aug 8, 2024
2 tasks
ivaylogarnev-limechain
pushed a commit
that referenced
this pull request
Aug 22, 2024
* feat: create node transaction (#2402) * feat: add addressBook channel Signed-off-by: svetoslav-nikol0v <[email protected]> * feat: implement NodeCreateTransaction class Signed-off-by: svetoslav-nikol0v <[email protected]> * feat: implement ServiceEndpoint class Signed-off-by: svetoslav-nikol0v <[email protected]> * chore: export new classess Signed-off-by: svetoslav-nikol0v <[email protected]> * update: proto changes Signed-off-by: svetoslav-nikol0v <[email protected]> * update: transaction receipt Signed-off-by: svetoslav-nikol0v <[email protected]> * fix: unit tests Signed-off-by: svetoslav-nikol0v <[email protected]> * fix: method in node create transaction Signed-off-by: svetoslav-nikol0v <[email protected]> --------- Signed-off-by: svetoslav-nikol0v <[email protected]> * fix: integration test Signed-off-by: svetoslav-nikol0v <[email protected]> * chore: remove .only Signed-off-by: svetoslav-nikol0v <[email protected]> * feat: node delete transaction (#2404) Signed-off-by: svetoslav-nikol0v <[email protected]> * feat: node update transaction (#2405) * feat: node update transaction Signed-off-by: svetoslav-nikol0v <[email protected]> * fix: adjustments Signed-off-by: svetoslav-nikol0v <[email protected]> --------- Signed-off-by: svetoslav-nikol0v <[email protected]> * update: example for HIP-869 (#2443) * chore: formatting Signed-off-by: Svet <[email protected]> * add: example Signed-off-by: Svet <[email protected]> * chore: formatting Signed-off-by: Svet <[email protected]> * update: example Signed-off-by: Svet <[email protected]> --------- Signed-off-by: Svet <[email protected]> * update: remove default values Signed-off-by: Svet <[email protected]> --------- Signed-off-by: svetoslav-nikol0v <[email protected]> Signed-off-by: Svet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This HIP-869 introduces the ability to manage the Address Book via HAPI endpoints within current Address Book implementation (config.txt, file 0.0.101,& file 0.0.102). In this phase HAPI endpoints are used to facilitate changes to the Address Book, however those changes are applied through existing, monthly upgrade process.
Related issue(s):
#2335 #2336 #2337 #2338 #2339 #2406 #2407
Checklist