-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert: mirror node queries changes #2328
Merged
svetoslav-nikol0v
merged 8 commits into
main
from
revert/mirror-node-queries-implementation-2289
Jun 12, 2024
Merged
revert: mirror node queries changes #2328
svetoslav-nikol0v
merged 8 commits into
main
from
revert/mirror-node-queries-implementation-2289
Jun 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: svetoslav-nikol0v <[email protected]>
svetoslav-nikol0v
requested review from
tomzhenghedera,
nathanklick and
rwalworth
and removed request for
nathanklick,
tomzhenghedera and
rwalworth
June 10, 2024 08:06
Signed-off-by: svetoslav-nikol0v <[email protected]>
svetoslav-nikol0v
changed the title
revert mirror node queries changes
revert: mirror node queries changes
Jun 10, 2024
Signed-off-by: svetoslav-nikol0v <[email protected]>
agadzhalov
previously approved these changes
Jun 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
svetoslav-nikol0v
force-pushed
the
revert/mirror-node-queries-implementation-2289
branch
from
June 12, 2024 06:55
1ec4527
to
302f131
Compare
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Quality Gate failedFailed conditions |
agadzhalov
approved these changes
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
svetoslav-nikol0v
deleted the
revert/mirror-node-queries-implementation-2289
branch
June 12, 2024 13:57
This was referenced Aug 31, 2024
This was referenced Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
After the decision of services to revert the changes related to the consensus queries in
0.50
version of the network, the changes related toAccountInfoQuery
,AccountBalanceQuery
andContractInfoQuery
were reverted as well.Checklist