Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: mirror node queries changes #2328

Merged

Conversation

svetoslav-nikol0v
Copy link
Contributor

@svetoslav-nikol0v svetoslav-nikol0v commented Jun 10, 2024

Description:

After the decision of services to revert the changes related to the consensus queries in 0.50 version of the network, the changes related to AccountInfoQuery, AccountBalanceQuery and ContractInfoQuery were reverted as well.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
@svetoslav-nikol0v svetoslav-nikol0v changed the title revert mirror node queries changes revert: mirror node queries changes Jun 10, 2024
Signed-off-by: svetoslav-nikol0v <[email protected]>
agadzhalov
agadzhalov previously approved these changes Jun 11, 2024
Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
@svetoslav-nikol0v svetoslav-nikol0v force-pushed the revert/mirror-node-queries-implementation-2289 branch from 1ec4527 to 302f131 Compare June 12, 2024 06:55
Signed-off-by: svetoslav-nikol0v <[email protected]>
Signed-off-by: svetoslav-nikol0v <[email protected]>
Copy link

sonarcloud bot commented Jun 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
50.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@agadzhalov agadzhalov self-requested a review June 12, 2024 13:46
Copy link
Contributor

@agadzhalov agadzhalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svetoslav-nikol0v svetoslav-nikol0v merged commit 484f0f9 into main Jun 12, 2024
8 of 9 checks passed
@svetoslav-nikol0v svetoslav-nikol0v deleted the revert/mirror-node-queries-implementation-2289 branch June 12, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants