Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Pause Key to TokenUpdateTransaction's fromProtobuf method #2095

Merged

Conversation

svetoslav-nikol0v
Copy link
Contributor

Description:

Added missing pauseKey prop to the method

Related issue(s):

Fixes #2094

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copy link

sonarcloud bot commented Jan 11, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (2af371e) 76.21% compared to head (a1715f7) 76.20%.

Files Patch % Lines
src/token/TokenUpdateTransaction.js 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2095      +/-   ##
===========================================
- Coverage    76.21%   76.20%   -0.01%     
===========================================
  Files          305      305              
  Lines        76064    76068       +4     
===========================================
- Hits         57973    57971       -2     
- Misses       18091    18097       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svetoslav-nikol0v svetoslav-nikol0v merged commit 72bd336 into develop Jan 11, 2024
6 of 9 checks passed
@svetoslav-nikol0v svetoslav-nikol0v deleted the 2094-add-a-pause-key-to-tokenupdatetransaction branch January 11, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Pause Key to TokenUpdateTransaction
2 participants