Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update dependencies and apply new linter rules #2043

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

ochikov
Copy link
Contributor

@ochikov ochikov commented Nov 28, 2023

Description:
Update dependecies:

  • SDK
  • Examples

Related issue(s):

Fixes #2037

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copy link

sonarcloud bot commented Nov 28, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
14.0% 14.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 491 lines in your changes are missing coverage. Please review.

Comparison is base (25880cc) 84.16% compared to head (f0a1e1a) 84.18%.
Report is 3 commits behind head on develop.

Files Patch % Lines
src/account/AccountAllowanceAdjustTransaction.js 0.00% 70 Missing ⚠️
src/account/AccountAllowanceApproveTransaction.js 50.00% 37 Missing ⚠️
src/transaction/Transaction.js 63.04% 17 Missing ⚠️
src/Cache.js 21.42% 11 Missing ⚠️
src/channel/NativeChannel.js 0.00% 11 Missing ⚠️
src/Executable.js 41.17% 10 Missing ⚠️
src/account/TokenNftAllowance.js 47.36% 10 Missing ⚠️
src/topic/TopicMessageQuery.js 28.57% 10 Missing ⚠️
src/account/AccountId.js 25.00% 9 Missing ⚠️
src/Wallet.js 50.00% 8 Missing ⚠️
... and 118 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2043      +/-   ##
===========================================
+ Coverage    84.16%   84.18%   +0.01%     
===========================================
  Files          304      304              
  Lines        75863    75884      +21     
===========================================
+ Hits         63852    63884      +32     
+ Misses       12011    12000      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svetoslav-nikol0v svetoslav-nikol0v merged commit 481172d into develop Dec 5, 2023
10 of 12 checks passed
@svetoslav-nikol0v svetoslav-nikol0v deleted the fix/update-dependecies branch December 5, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update SDK package versions
2 participants