Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mapi call that queries the mirror node to get the actual evm address field #1853

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

petreze
Copy link
Contributor

@petreze petreze commented Sep 4, 2023

Description:
Add populateAccountEvmAddress() method to AccountId class that queries and gets the actual evm address field from the mirror node

Related issue(s):

Fixes #1817

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@sonarcloud
Copy link

sonarcloud bot commented Sep 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@petreze petreze merged commit 802427c into develop Sep 4, 2023
9 of 10 checks passed
@petreze petreze deleted the fix/mapi-populate-address branch September 4, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: AccountId#toSolidityAddress() does not return expected result when AccountId has a Key Alias
2 participants