Fix deprecation and add comments #1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: Petar Tonev <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
petreze
added a commit
that referenced
this pull request
Aug 22, 2023
* Add retry logic on grpc web errors (#1802) * add retry logic Signed-off-by: Petar Tonev <[email protected]> * add retry logic for fetch api errors Signed-off-by: Petar Tonev <[email protected]> --------- Signed-off-by: Petar Tonev <[email protected]> * prepare for release Signed-off-by: Petar Tonev <[email protected]> * comment out unavailable nodes (#1810) Signed-off-by: Petar Tonev <[email protected]> * prepare for release Signed-off-by: Petar Tonev <[email protected]> * Fix deprecation and add comments (#1811) * restore troublesome nodes in constants Signed-off-by: Petar Tonev <[email protected]> * add method descriptions and deprecate fromSolidityAddress Signed-off-by: Petar Tonev <[email protected]> --------- Signed-off-by: Petar Tonev <[email protected]> * prepare for stable release Signed-off-by: Petar Tonev <[email protected]> --------- Signed-off-by: Petar Tonev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR deprecates
AccountId/ContractId.fromSolidityAddress()and adds several descriptionsRelated issue(s):
Fixes #1814
Notes for reviewer:
Checklist