Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DER and PEM headers #1706

Merged
merged 14 commits into from
Jul 17, 2023
Merged

Fix DER and PEM headers #1706

merged 14 commits into from
Jul 17, 2023

Conversation

petreze
Copy link
Contributor

@petreze petreze commented Jul 5, 2023 •
edited
Loading

Description:
Fix decoding private keys from both PEM and DER headers. Add additional exception handling, add tips in README on how to use the SDK in React Native environment

Related issue(s):

Fixes #1648 #1494

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

petreze added 12 commits May 18, 2023 11:04
@petreze
added test vectors for PEM/DER keys
22bf450 
Signed-off-by: Petar Tonev <[email protected]>
@petreze
partial work
1c77751 
Signed-off-by: Petar Tonev <[email protected]>
@petreze
pem and der work in node and browser
fefe135 
Signed-off-by: Petar Tonev <[email protected]>
@petreze
merge develop into fix/der-header
30d8f6d 
Signed-off-by: Petar Tonev <[email protected]>
@petreze
build packages
ca08c9f 
Signed-off-by: Petar Tonev <[email protected]>
@petreze
partial work
842facf 
Signed-off-by: Petar Tonev <[email protected]>
@petreze
fixed react-native environment
74c3d00 
Signed-off-by: Petar Tonev <[email protected]>
@petreze
clear a bit
732feaf 
Signed-off-by: Petar Tonev <[email protected]>
@petreze
merge develop into current
37c5215 
Signed-off-by: Petar Tonev <[email protected]>
@petreze
edit readme and provide tips and tricks
0292412 
Signed-off-by: Petar Tonev <[email protected]>
@petreze
prepare cryptography package for release
deec652 
Signed-off-by: Petar Tonev <[email protected]>
@petreze
point the SDK to use the newest version of the cryptography package
0f6f8aa 
Signed-off-by: Petar Tonev <[email protected]>
@petreze petreze linked an issue Jul 5, 2023 that may be closed by this pull request
Calculate the DER prefix when encoding keys instead of just adding a prefix #1494
Closed
@ochikov
Copy link
Contributor

ochikov commented Jul 6, 2023

LGTM

@dikel dikel mentioned this pull request Jul 17, 2023
Closed
@petreze petreze merged commit af8d74b into develop Jul 17, 2023
@petreze petreze deleted the fix/der-header branch July 17, 2023 08:30
@sonarcloud
Copy link

sonarcloud bot commented Jul 17, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 15 Code Smells

No Coverage information No Coverage information
2.6% 2.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimiHunjan SimiHunjan Awaiting requested review from SimiHunjan

@ochikov ochikov Awaiting requested review from ochikov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@petreze @ochikov