Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new transaction type based on EIP-2930 #1702

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

rokn
Copy link
Contributor

@rokn rokn commented Jul 3, 2023

Description:
This PR adds the transaction type defined in EIP-2930 when parsing EthereumData from bytes.

Related issue(s):

Fixes #1615

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@sonarcloud
Copy link

sonarcloud bot commented Jul 3, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
33.7% 33.7% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@ochikov ochikov merged commit f66dce0 into develop Jul 3, 2023
@ochikov ochikov deleted the fix/1615-ethereum-transaction-from-bytes branch July 3, 2023 14:52
monokaijs pushed a commit to monostarter/u2u-sdk-js that referenced this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Research about EthereumTransactionData.fromBytes
2 participants