Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assessment method support for custom fractional fees #1600

Merged
merged 1 commit into from
May 2, 2023

Conversation

petreze
Copy link
Contributor

@petreze petreze commented May 2, 2023

Description:
This PR fixes an issue where there is no impact no matter the value being set to setAssessmentMethod()

Related issue(s):

Fixes #1598

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@petreze petreze changed the title add assessment method support for custom fractional fees Add assessment method support for custom fractional fees May 2, 2023
@petreze petreze merged commit 9179c1f into develop May 2, 2023
@petreze petreze deleted the fix/fractional-fee-assessment branch May 2, 2023 11:47
monokaijs pushed a commit to monostarter/u2u-sdk-js that referenced this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setAssessmentMethod() does not work
1 participant