Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature add alias support in AccountCreateTX #1563

Merged
merged 4 commits into from
Apr 20, 2023

Conversation

petreze
Copy link
Contributor

@petreze petreze commented Apr 19, 2023

Description:
This PR adds the supportability to set alias when AccountCreateTransaction is performed

Related issue(s):

Fixes #1483

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Petar Tonev <[email protected]>
Signed-off-by: Petar Tonev <[email protected]>
test/integration/AccountCreateIntegrationTest.js Outdated Show resolved Hide resolved
test/integration/AccountCreateIntegrationTest.js Outdated Show resolved Hide resolved
@petreze petreze marked this pull request as draft April 19, 2023 11:49
@sonarcloud
Copy link

sonarcloud bot commented Apr 20, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
6.8% 6.8% Duplication

@petreze petreze marked this pull request as ready for review April 20, 2023 08:21
@petreze petreze requested a review from ochikov April 20, 2023 08:21
@ochikov ochikov merged commit e445a9c into develop Apr 20, 2023
@ochikov ochikov deleted the feature/alias-support-hip583 branch April 20, 2023 12:18
monokaijs pushed a commit to monostarter/u2u-sdk-js that referenced this pull request Jul 5, 2023
* partial work

Signed-off-by: Petar Tonev <[email protected]>

* add integration tests

Signed-off-by: Petar Tonev <[email protected]>

* point integration tests for hip583 features to previewnet for now

Signed-off-by: Petar Tonev <[email protected]>

* use env local client

Signed-off-by: Petar Tonev <[email protected]>

---------

Signed-off-by: Petar Tonev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HIP-583 Expand alias support AccountCreateTransaction
2 participants