Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in deprecation suggestion #1352

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Conversation

ochikov
Copy link
Contributor

@ochikov ochikov commented Dec 8, 2022

Description:
Fix typo in the deprecation suggestion for PrivateKey::generate

Related issue(s):

Fixes #1341

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@sonarcloud
Copy link

sonarcloud bot commented Dec 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Base: 83.54% // Head: 74.74% // Decreases project coverage by -8.79% ⚠️

Coverage data is based on head (cb0d37c) compared to base (dfc5c87).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1352      +/-   ##
===========================================
- Coverage    83.54%   74.74%   -8.80%     
===========================================
  Files          292      255      -37     
  Lines        72854    63798    -9056     
===========================================
- Hits         60864    47689   -13175     
- Misses       11990    16109    +4119     
Impacted Files Coverage Δ
src/PrivateKey.js 92.09% <100.00%> (ø)
src/token/TokenInfo.js 21.55% <0.00%> (-61.78%) ⬇️
src/schedule/ScheduleInfo.js 26.61% <0.00%> (-58.56%) ⬇️
src/contract/ContractInfo.js 30.28% <0.00%> (-56.34%) ⬇️
src/network/AddressBookQuery.js 35.16% <0.00%> (-55.68%) ⬇️
src/account/TokenRelationship.js 39.86% <0.00%> (-53.15%) ⬇️
src/topic/TopicInfo.js 32.88% <0.00%> (-49.55%) ⬇️
src/file/FileInfo.js 45.45% <0.00%> (-42.86%) ⬇️
src/token/TokenMintTransaction.js 52.89% <0.00%> (-40.22%) ⬇️
src/contract/ContractCallQuery.js 46.68% <0.00%> (-37.76%) ⬇️
... and 129 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ochikov ochikov merged commit d7016ca into develop Dec 9, 2022
@ochikov ochikov deleted the fix/deprecated-pk-generate branch December 9, 2022 12:08
monokaijs pushed a commit to monostarter/u2u-sdk-js that referenced this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generateEd25519Async() should be referenced in the depredated note of PrivateKey.generate()
2 participants