Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for optional param of transaction range #1339

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

ochikov
Copy link
Contributor

@ochikov ochikov commented Nov 28, 2022

Signed-off-by: ochikov [email protected]

Description:
Fix for optimal param of transaction range when using PrngTransaction
Related issue(s):

Fixes #1338

Notes for reviewer:
Using ?. the sdk can be build, but it cannot be used into React.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Base: 83.51% // Head: 83.45% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (e85bdc7) compared to base (ea3176e).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1339      +/-   ##
===========================================
- Coverage    83.51%   83.45%   -0.07%     
===========================================
  Files          292      292              
  Lines        72849    72847       -2     
===========================================
- Hits         60837    60791      -46     
- Misses       12012    12056      +44     
Impacted Files Coverage Δ
src/PrngTransaction.js 93.52% <100.00%> (+0.07%) ⬆️
src/network/AddressBookQuery.js 73.26% <0.00%> (-17.59%) ⬇️
src/token/TokenNftInfo.js 85.80% <0.00%> (+2.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ochikov ochikov merged commit f374583 into develop Nov 28, 2022
@ochikov ochikov deleted the fix/body-util-prng-range branch November 28, 2022 12:55
monokaijs pushed a commit to monostarter/u2u-sdk-js that referenced this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Module parse failed: Unexpected token (109:43) const transactionRange = body.utilPrng?.range
2 participants