Fix the offset for uint24 & int24 datatypes in contract functions params #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ochikov
requested review from
janaakhterov,
mehcode and
SimiHunjan
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
janaakhterov
approved these changes
Oct 14, 2022
petreze
approved these changes
Oct 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix the offset for the Uint24 & Int24 Contract Function Params
Related issue(s):
Fixes #1294
Notes for reviewer:
The offset of Uint24 & Int24 needs to be changed. It is because they are cast to Uint32 & Int32.
Checklist