Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace /common/abi module #1127

Merged
merged 5 commits into from
Nov 8, 2024
Merged

chore: replace /common/abi module #1127

merged 5 commits into from
Nov 8, 2024

Conversation

0xivanov
Copy link
Contributor

@0xivanov 0xivanov commented Nov 5, 2024

Description:
Replace /common/abi from go-ethereum

Related issue(s):

Fixes #1111

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Ivan Ivanov <[email protected]>
@0xivanov 0xivanov self-assigned this Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 62.64090% with 464 lines in your changes missing coverage. Please review.

Project coverage is 73.33%. Comparing base (457eb5e) to head (75080d3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
abi_encode.go 47.58% 109 Missing and 21 partials ⚠️
abi_decode.go 54.09% 113 Missing and 16 partials ⚠️
abi.go 59.70% 85 Missing and 23 partials ⚠️
abi_type.go 78.19% 77 Missing and 17 partials ⚠️
crypto.go 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1127      +/-   ##
==========================================
- Coverage   73.99%   73.33%   -0.66%     
==========================================
  Files         177      181       +4     
  Lines       21858    23097    +1239     
==========================================
+ Hits        16173    16938     +765     
- Misses       5009     5406     +397     
- Partials      676      753      +77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ivan Ivanov <[email protected]>
@0xivanov 0xivanov marked this pull request as ready for review November 7, 2024 08:44
@0xivanov 0xivanov requested review from a team as code owners November 7, 2024 08:45
Signed-off-by: Ivan Ivanov <[email protected]>
Copy link
Contributor

@gsstoykov gsstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LG, just some final grooming suggestions.

abi.go Outdated Show resolved Hide resolved
abi.go Outdated Show resolved Hide resolved
abi_decode.go Outdated Show resolved Hide resolved
abi_encode.go Show resolved Hide resolved
ethereum_transaction_e2e_test.go Outdated Show resolved Hide resolved
abi_encode.go Show resolved Hide resolved
Copy link

sonarcloud bot commented Nov 8, 2024

@0xivanov 0xivanov merged commit 2c22da8 into main Nov 8, 2024
11 of 13 checks passed
@0xivanov 0xivanov deleted the replace-/abi-module branch November 8, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace /common/abi from go-ethereum
2 participants