Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename files to be lower_snake_case #74

Merged
merged 2 commits into from
Aug 19, 2021
Merged

Rename files to be lower_snake_case #74

merged 2 commits into from
Aug 19, 2021

Conversation

janaakhterov
Copy link
Contributor

Description:

Updates all protobuf files to be lower_snake_case to follow protobuf style guide https://developers.google.com/protocol-buffers/docs/style
Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Daniel Akhterov <[email protected]>
Signed-off-by: Daniel Akhterov <[email protected]>
Copy link
Member

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please also submit a PR to hedera-docs to update any linked references to proto files.

Copy link
Contributor

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed everything still works with this naming convention, LGTM!

@tinker-michaelj tinker-michaelj merged commit 0954fab into hashgraph:develop Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants