Add RoyaltyFee custom fee type #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 8, 2021 11:17
Signed-off-by: tinker-michaelj <[email protected]>
Signed-off-by: tinker-michaelj <[email protected]>
tinker-michaelj
requested review from
steven-sheehy,
xin-hedera,
qnswirlds and
SimiHunjan
added 2 commits
August 8, 2021 11:23
Signed-off-by: tinker-michaelj <[email protected]>
Signed-off-by: tinker-michaelj <[email protected]>
|
it's possible when the fungible value in exchange for the |
qnswirlds
reviewed
Aug 9, 2021
| @@ -251,7 +251,7 @@ enum ResponseCodeEnum { | |||
| CUSTOM_FEE_MUST_BE_POSITIVE = 239; // Only positive fees may be assessed at this time | |||
| TOKEN_HAS_NO_FEE_SCHEDULE_KEY = 240; // Fee schedule key is not set on token | |||
| CUSTOM_FEE_OUTSIDE_NUMERIC_RANGE = 241; // A fractional custom fee exceeded the range of a 64-bit signed integer | |||
| INVALID_CUSTOM_FRACTIONAL_FEES_SUM = 242; // The sum of all custom fractional fees must be strictly less than 1 | |||
There was a problem hiding this comment.
If we still keep the FractionalFee, I think we should also keep this INVALID_CUSTOM_FRACTIONAL_FEES_SUM response code.
Interesting question. 🤔 It seems we would need a separate minimum for each of the fungible tokens the fee collector accepts, which could make the feature somewhat elaborate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
RoyaltyFeemessage needed by AddRoyaltyFeeto custom HTS fee types hedera-services#1935; please see that issue for details.