Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename TokenGetAccountNftInfo + add new Response code #44

Merged
merged 14 commits into from
Jun 30, 2021
Merged
4 changes: 2 additions & 2 deletions services/BasicTypes.proto
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ message TransferList {
repeated AccountAmount accountAmounts = 1; // Multiple list of AccountAmount pairs, each of which has an account and an amount to transfer into it (positive) or out of it (negative)
}

/* A sender account, a receiver account, and the serial number of an NFT of a Token with NON_FUNGIBLE_UNIQUE type. */
/* A sender account, a receiver account, and the serial number of an NFT of a Token with NON_FUNGIBLE_UNIQUE type. When minting NFTs the sender will be the default AccountID instance (0.0.0) and when burning NFTs, the receiver will be the default AccountID instance. */
message NftTransfer {
AccountID senderAccountID = 1; // The accountID of the sender
AccountID receiverAccountID = 2; // The accountID of the receiver
Expand Down Expand Up @@ -333,7 +333,7 @@ enum HederaFunctionality {
ScheduleDelete = 71; // Delete Scheduled Transaction
ScheduleSign = 72; // Sign Scheduled Transaction
ScheduleGetInfo = 73; // Get Scheduled Transaction Information
TokenGetAccountNftInfo = 74; // Get Token Account Nft Information
TokenGetAccountNftInfos = 74; // Get Token Account Nft Information
TokenGetNftInfo = 75; // Get Token Nft Information
TokenGetNftInfos = 76; // Get Token Nft List Information
}
Expand Down
4 changes: 2 additions & 2 deletions services/Query.proto
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ import "NetworkGetVersionInfo.proto";
import "TokenGetInfo.proto";
import "ScheduleGetInfo.proto";

import "TokenGetAccountNftInfo.proto";
import "TokenGetAccountNftInfos.proto";
import "TokenGetNftInfo.proto";
import "TokenGetNftInfos.proto";

Expand Down Expand Up @@ -86,7 +86,7 @@ message Query {

ScheduleGetInfoQuery scheduleGetInfo = 53; // Get all information about a scheduled entity

TokenGetAccountNftInfoQuery tokenGetAccountNftInfo = 54; // Get a list of NFTs associated with the account
TokenGetAccountNftInfosQuery tokenGetAccountNftInfos = 54; // Get a list of NFTs associated with the account
TokenGetNftInfoQuery tokenGetNftInfo = 55; // Get all information about a NFT
TokenGetNftInfosQuery tokenGetNftInfos = 56; // Get a list of NFTs for the token
}
Expand Down
4 changes: 2 additions & 2 deletions services/Response.proto
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ import "ConsensusGetTopicInfo.proto";

import "NetworkGetVersionInfo.proto";

import "TokenGetAccountNftInfo.proto";
import "TokenGetAccountNftInfos.proto";
import "TokenGetInfo.proto";
import "TokenGetNftInfo.proto";
import "TokenGetNftInfos.proto";
Expand Down Expand Up @@ -90,7 +90,7 @@ message Response {

ScheduleGetInfoResponse scheduleGetInfo = 153; // Get all information about a schedule entity

TokenGetAccountNftInfoResponse tokenGetAccountNftInfo = 154; // A list of the NFTs associated with the account
TokenGetAccountNftInfosResponse tokenGetAccountNftInfos = 154; // A list of the NFTs associated with the account
TokenGetNftInfoResponse tokenGetNftInfo = 155; // All information about an NFT
TokenGetNftInfosResponse tokenGetNftInfos = 156; // A list of the NFTs for the token
}
Expand Down
2 changes: 1 addition & 1 deletion services/ResponseCode.proto
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,7 @@ enum ResponseCodeEnum {
INVALID_NFT_ID = 226; // Invalid nft id
METADATA_TOO_LONG = 227; // Nft metadata is too long
BATCH_SIZE_LIMIT_EXCEEDED = 228; // Repeated operations count exceeds the limit
QUERY_RANGE_LIMIT_EXCEEDED = 229; // The range of data to be gathered exceeds the limit
INVALID_QUERY_RANGE = 229; // The range of data to be gathered is out of the set boundaries
FRACTION_DIVIDES_BY_ZERO = 230; // A custom fractional fee set a denominator of zero
INSUFFICIENT_PAYER_BALANCE_FOR_CUSTOM_FEE = 231; // The transaction payer could not afford a custom fee
CUSTOM_FEES_LIST_TOO_LONG = 232; // The customFees list is longer than allowed limit 10
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,14 @@ import "ResponseHeader.proto";
/* Applicable only to tokens of type NON_FUNGIBLE_UNIQUE. Gets info on NFTs N through M owned by the specified accountId.
* Example: If Account A owns 5 NFTs (might be of different Token Entity), having start=0 and end=5 will return all of the NFTs
*/
message TokenGetAccountNftInfoQuery {
message TokenGetAccountNftInfosQuery {
QueryHeader header = 1; // Standard info sent from client to node, including the signed payment, and what kind of response is requested (cost, state proof, both, or neither).
AccountID accountID = 2; // The Account for which information is requested
int64 start = 3; // Specifies the start index (inclusive) of the range of NFTs to query for. Value must be in the range [0; ownedNFTs-1]
int64 end = 4; // Specifies the end index (exclusive) of the range of NFTs to query for. Value must be in the range (start; ownedNFTs]
}

message TokenGetAccountNftInfoResponse {
message TokenGetAccountNftInfosResponse {
ResponseHeader header = 1; // Standard response from node to client, including the requested fields: cost, or state proof, or both, or neither
repeated TokenNftInfo nfts = 2; // List of NFTs associated to the account
}
2 changes: 1 addition & 1 deletion services/TokenService.proto
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ service TokenService {
// Retrieves the metadata of a token
rpc getTokenInfo (Query) returns (Response);
// Gets info on NFTs N through M on the list of NFTs associated with a given account
rpc getAccountNftInfo (Query) returns (Response);
rpc getAccountNftInfos (Query) returns (Response);
// Retrieves the metadata of an NFT by TokenID and serial number
rpc getTokenNftInfo (Query) returns (Response);
// Gets info on NFTs N through M on the list of NFTs associated with a given Token of type NON_FUNGIBLE
Expand Down
2 changes: 1 addition & 1 deletion services/TransactionReceipt.proto
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ message TransactionReceipt {
// In the receipt of a CreateToken, the id of the newly created token
TokenID tokenID = 10;

// In the receipt of TokenMint, TokenWipe, TokenBurn, the current total supply of this token
// In the receipt of TokenMint, TokenWipe, TokenBurn, For fungible tokens - the current total supply of this token. For non fungible tokens - the total number of NFTs issued for a given tokenID
uint64 newTotalSupply = 11;

// In the receipt of a ScheduleCreate, the id of the newly created Scheduled Entity
Expand Down