-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating comments #260
Open
nickpoorman
wants to merge
2
commits into
main
Choose a base branch
from
nickpoorman-patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Updating comments #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Poorman <[email protected]>
nickpoorman
force-pushed
the
nickpoorman-patch-1
branch
from
March 20, 2023 21:08
c30db58
to
a225acc
Compare
jascks
previously approved these changes
Mar 20, 2023
steven-sheehy
previously approved these changes
Mar 20, 2023
nickpoorman
force-pushed
the
nickpoorman-patch-1
branch
from
March 20, 2023 23:41
f123db9
to
5e34961
Compare
Signed-off-by: Nick Poorman <[email protected]> Signed-off-by: Nick Poorman <[email protected]>
nickpoorman
force-pushed
the
nickpoorman-patch-1
branch
from
March 20, 2023 23:44
5e34961
to
53c086f
Compare
povolev15
approved these changes
Mar 21, 2023
jascks
approved these changes
Mar 21, 2023
mhess-swl
approved these changes
Mar 28, 2023
Neeharika-Sompalli
approved these changes
Mar 28, 2023
tinker-michaelj
approved these changes
Mar 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes documentation comment.