-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove incorrect comment #111
Open
SimiHunjan
wants to merge
2
commits into
develop
Choose a base branch
from
update-comments
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reference node properties controlling HTS behavior Signed-off-by: tinker-michaelj <[email protected]> * Again clarify use of master Signed-off-by: tinker-michaelj <[email protected]> * Update from head of schedule-develop in hashgraph/hedera-services (#2) Signed-off-by: tinker-michaelj <[email protected]> * Standardize memos for non-schedule entities (#3) * Standardize memos for non-schedule entities Signed-off-by: tinker-michaelj <[email protected]> * Fix typo in field number Signed-off-by: tinker-michaelj <[email protected]> * Use google.protobuf.StringValue for new memo fields Signed-off-by: tinker-michaelj <[email protected]> * Comment on deprecated memoField choice Signed-off-by: tinker-michaelj <[email protected]> * Port schedule txn comments (#5) * Port schedule txn comments Signed-off-by: tinker-michaelj <[email protected]> * Add further comments Signed-off-by: tinker-michaelj <[email protected]> * Apply the same changes to hedera-protobufs repo. (#4) Signed-off-by: ljianghedera <[email protected]> Co-authored-by: ljianghedera <[email protected]> * Separate messages used for balances proto under hedera/streams (#6) * Separate messages used for balances proto under hedera/streams Signed-off-by: tinker-michaelj <[email protected]> * Restructure proto directories Signed-off-by: tinker-michaelj <[email protected]> * Change java_package for AccountBalanceFile.proto messages Signed-off-by: tinker-michaelj <[email protected]> * Extract TokenBalance(s) to BasicTypes Signed-off-by: tinker-michaelj <[email protected]> * Include decimals in queries of token/account balances and relationships (#8) Signed-off-by: tinker-michaelj <[email protected]> * Include Leemon's edits from Services issue #974 (#10) Signed-off-by: tinker-michaelj <[email protected]> * Add scheduled transaction id to TransactionReceipt + ScheduleGetInfo types (#12) * Prepare to tag 0.12.0 release (#11) * Reference node properties controlling HTS behavior Signed-off-by: tinker-michaelj <[email protected]> * Again clarify use of master Signed-off-by: tinker-michaelj <[email protected]> * Update from head of schedule-develop in hashgraph/hedera-services (#2) Signed-off-by: tinker-michaelj <[email protected]> * Standardize memos for non-schedule entities (#3) * Standardize memos for non-schedule entities Signed-off-by: tinker-michaelj <[email protected]> * Fix typo in field number Signed-off-by: tinker-michaelj <[email protected]> * Use google.protobuf.StringValue for new memo fields Signed-off-by: tinker-michaelj <[email protected]> * Comment on deprecated memoField choice Signed-off-by: tinker-michaelj <[email protected]> * Port schedule txn comments (#5) * Port schedule txn comments Signed-off-by: tinker-michaelj <[email protected]> * Add further comments Signed-off-by: tinker-michaelj <[email protected]> * Apply the same changes to hedera-protobufs repo. (#4) Signed-off-by: ljianghedera <[email protected]> Co-authored-by: ljianghedera <[email protected]> * Separate messages used for balances proto under hedera/streams (#6) * Separate messages used for balances proto under hedera/streams Signed-off-by: tinker-michaelj <[email protected]> * Restructure proto directories Signed-off-by: tinker-michaelj <[email protected]> * Change java_package for AccountBalanceFile.proto messages Signed-off-by: tinker-michaelj <[email protected]> * Extract TokenBalance(s) to BasicTypes Signed-off-by: tinker-michaelj <[email protected]> * Include decimals in queries of token/account balances and relationships (#8) Signed-off-by: tinker-michaelj <[email protected]> * Include Leemon's edits from Services issue #974 (#10) Signed-off-by: tinker-michaelj <[email protected]> Co-authored-by: ljianghedera <[email protected]> * Update README.md * Add scheduledTransactionID fields to TransactionReceipt and ScheduleGetInfo Signed-off-by: tinker-michaelj <[email protected]> * Update README Signed-off-by: tinker-michaelj <[email protected]> Co-authored-by: ljianghedera <[email protected]> * 00017 d hcs message size (#19) * Add response code for Hcs message size limit. Signed-off-by: ljianghedera <[email protected]> * Add the response code for HCS message too large. Signed-off-by: ljianghedera <[email protected]> * Update protobufs to satisfy revised scheduled txns spec (#15) * Update protobufs to satisfy revised scheduled txns spec Signed-off-by: tinker-michaelj <[email protected]> * Improve comment readability Signed-off-by: tinker-michaelj <[email protected]> * Make explicit mention of scheduling.whitelist Signed-off-by: tinker-michaelj <[email protected]> * Incorporate reviewer feedback Signed-off-by: tinker-michaelj <[email protected]> * Standardize on payerAccountID Signed-off-by: tinker-michaelj <[email protected]> * Add scheduledTransactionID to ScheduleInfo Signed-off-by: tinker-michaelj <[email protected]> * Clarify effects of schedule deletion Signed-off-by: tinker-michaelj <[email protected]> * Include expiration time in getScheduleInfo response Signed-off-by: tinker-michaelj <[email protected]> * Change now-obsolete UNPARSEABLE_SCHEDULED_TRANSACTION response code to SCHEDULED_TRANSACTION_NOT_IN_WHITELIST; remove UNSCHEDULABLE_TRANSACTION Signed-off-by: tinker-michaelj <[email protected]> * Remove unneeded imports Signed-off-by: tinker-michaelj <[email protected]> * Replace deleted/executed flags with consensus timestamps Signed-off-by: tinker-michaelj <[email protected]> * Update info on ScheduleCreate receipt on duplicate creation Signed-off-by: tinker-michaelj <[email protected]> * Incorporate reviewer feedback Signed-off-by: tinker-michaelj <[email protected]> * Use oneof to enforce mutual exclusion of schedule deletion and execution Signed-off-by: tinker-michaelj <[email protected]> * Use lower_snake_case for field names in oneof to ease transition to standard naming convention Signed-off-by: tinker-michaelj <[email protected]> * Redirect to ResponseCode doc section from Schedule* ops Signed-off-by: tinker-michaelj <[email protected]> * Add ThrottleDefinitions types (#23) * Create ThrottleDefinitions message Signed-off-by: tinker-michaelj <[email protected]> * Add throttle-specific response codes Signed-off-by: tinker-michaelj <[email protected]> * Add more general response codes for throttle defs Signed-off-by: tinker-michaelj <[email protected]> * Add comments to the throttle types Signed-off-by: tinker-michaelj <[email protected]> * Clarify some comments Signed-off-by: tinker-michaelj <[email protected]> * Update to milliOpsPerSec/burstPeriodMs Signed-off-by: tinker-michaelj <[email protected]> * Fix typo Signed-off-by: tinker-michaelj <[email protected]> * Be more concise Signed-off-by: tinker-michaelj <[email protected]> * Be explicit about milli-ops Signed-off-by: tinker-michaelj <[email protected]> * Emphasize only ed25519 keys are supported (#26) Signed-off-by: tinker-michaelj <[email protected]> * Revise address book types to 0.13.0 standard (#27) * Update to final version of address book messages Signed-off-by: tinker-michaelj <[email protected]> * Align with issue 750 consensus format Signed-off-by: tinker-michaelj <[email protected]> * Change ServiceEndpoint types Signed-off-by: tinker-michaelj <[email protected]> * Match comments from issue Signed-off-by: tinker-michaelj <[email protected]> * Update comment Signed-off-by: tinker-michaelj <[email protected]> * Add details Signed-off-by: tinker-michaelj <[email protected]> * Specify fallback use of deprecated fields Signed-off-by: tinker-michaelj <[email protected]> * Minor revision Signed-off-by: tinker-michaelj <[email protected]> * Add full semver meta to SemanticVersion (#33) * Add full semver meta to SemanticVersion Signed-off-by: tinker-michaelj <[email protected]> * Add top-level comment on SemanticVersion Signed-off-by: tinker-michaelj <[email protected]> * Abbreviate SemanticVersion optional fields Signed-off-by: tinker-michaelj <[email protected]> * Add ACCOUNT_EXPIRED_AND_PENDING_REMOVAL response code (#35) Signed-off-by: tinker-michaelj <[email protected]> * Feature: NFT Tokens (#37) * feat(tokens): nfts Signed-off-by: failfmi <[email protected]> * feat: multiple fee data per hedera functionality; sub type distinguishing different fee data Signed-off-by: failfmi <[email protected]> * deprecate feedata property Signed-off-by: Daniel Ivanov <[email protected]> * style: rename repeated fee data field Signed-off-by: failfmi <[email protected]> * Error ResponseCodes Signed-off-by: Georgi Yazovaliyski <[email protected]> Co-authored-by: Daniel Ivanov <[email protected]> Co-authored-by: Georgi Yazovaliyski <[email protected]> * Sync develop with main (#38) * Prepare for 0.13.0 tag (#28) * Reference node properties controlling HTS behavior Signed-off-by: tinker-michaelj <[email protected]> * Again clarify use of master Signed-off-by: tinker-michaelj <[email protected]> * Update from head of schedule-develop in hashgraph/hedera-services (#2) Signed-off-by: tinker-michaelj <[email protected]> * Standardize memos for non-schedule entities (#3) * Standardize memos for non-schedule entities Signed-off-by: tinker-michaelj <[email protected]> * Fix typo in field number Signed-off-by: tinker-michaelj <[email protected]> * Use google.protobuf.StringValue for new memo fields Signed-off-by: tinker-michaelj <[email protected]> * Comment on deprecated memoField choice Signed-off-by: tinker-michaelj <[email protected]> * Port schedule txn comments (#5) * Port schedule txn comments Signed-off-by: tinker-michaelj <[email protected]> * Add further comments Signed-off-by: tinker-michaelj <[email protected]> * Apply the same changes to hedera-protobufs repo. (#4) Signed-off-by: ljianghedera <[email protected]> Co-authored-by: ljianghedera <[email protected]> * Separate messages used for balances proto under hedera/streams (#6) * Separate messages used for balances proto under hedera/streams Signed-off-by: tinker-michaelj <[email protected]> * Restructure proto directories Signed-off-by: tinker-michaelj <[email protected]> * Change java_package for AccountBalanceFile.proto messages Signed-off-by: tinker-michaelj <[email protected]> * Extract TokenBalance(s) to BasicTypes Signed-off-by: tinker-michaelj <[email protected]> * Include decimals in queries of token/account balances and relationships (#8) Signed-off-by: tinker-michaelj <[email protected]> * Include Leemon's edits from Services issue #974 (#10) Signed-off-by: tinker-michaelj <[email protected]> * Add scheduled transaction id to TransactionReceipt + ScheduleGetInfo types (#12) * Prepare to tag 0.12.0 release (#11) * Reference node properties controlling HTS behavior Signed-off-by: tinker-michaelj <[email protected]> * Again clarify use of master Signed-off-by: tinker-michaelj <[email protected]> * Update from head of schedule-develop in hashgraph/hedera-services (#2) Signed-off-by: tinker-michaelj <[email protected]> * Standardize memos for non-schedule entities (#3) * Standardize memos for non-schedule entities Signed-off-by: tinker-michaelj <[email protected]> * Fix typo in field number Signed-off-by: tinker-michaelj <[email protected]> * Use google.protobuf.StringValue for new memo fields Signed-off-by: tinker-michaelj <[email protected]> * Comment on deprecated memoField choice Signed-off-by: tinker-michaelj <[email protected]> * Port schedule txn comments (#5) * Port schedule txn comments Signed-off-by: tinker-michaelj <[email protected]> * Add further comments Signed-off-by: tinker-michaelj <[email protected]> * Apply the same changes to hedera-protobufs repo. (#4) Signed-off-by: ljianghedera <[email protected]> Co-authored-by: ljianghedera <[email protected]> * Separate messages used for balances proto under hedera/streams (#6) * Separate messages used for balances proto under hedera/streams Signed-off-by: tinker-michaelj <[email protected]> * Restructure proto directories Signed-off-by: tinker-michaelj <[email protected]> * Change java_package for AccountBalanceFile.proto messages Signed-off-by: tinker-michaelj <[email protected]> * Extract TokenBalance(s) to BasicTypes Signed-off-by: tinker-michaelj <[email protected]> * Include decimals in queries of token/account balances and relationships (#8) Signed-off-by: tinker-michaelj <[email protected]> * Include Leemon's edits from Services issue #974 (#10) Signed-off-by: tinker-michaelj <[email protected]> Co-authored-by: ljianghedera <[email protected]> * Update README.md * Add scheduledTransactionID fields to TransactionReceipt and ScheduleGetInfo Signed-off-by: tinker-michaelj <[email protected]> * Update README Signed-off-by: tinker-michaelj <[email protected]> Co-authored-by: ljianghedera <[email protected]> * 00017 d hcs message size (#19) * Add response code for Hcs message size limit. Signed-off-by: ljianghedera <[email protected]> * Add the response code for HCS message too large. Signed-off-by: ljianghedera <[email protected]> * Update protobufs to satisfy revised scheduled txns spec (#15) * Update protobufs to satisfy revised scheduled txns spec Signed-off-by: tinker-michaelj <[email protected]> * Improve comment readability Signed-off-by: tinker-michaelj <[email protected]> * Make explicit mention of scheduling.whitelist Signed-off-by: tinker-michaelj <[email protected]> * Incorporate reviewer feedback Signed-off-by: tinker-michaelj <[email protected]> * Standardize on payerAccountID Signed-off-by: tinker-michaelj <[email protected]> * Add scheduledTransactionID to ScheduleInfo Signed-off-by: tinker-michaelj <[email protected]> * Clarify effects of schedule deletion Signed-off-by: tinker-michaelj <[email protected]> * Include expiration time in getScheduleInfo response Signed-off-by: tinker-michaelj <[email protected]> * Change now-obsolete UNPARSEABLE_SCHEDULED_TRANSACTION response code to SCHEDULED_TRANSACTION_NOT_IN_WHITELIST; remove UNSCHEDULABLE_TRANSACTION Signed-off-by: tinker-michaelj <[email protected]> * Remove unneeded imports Signed-off-by: tinker-michaelj <[email protected]> * Replace deleted/executed flags with consensus timestamps Signed-off-by: tinker-michaelj <[email protected]> * Update info on ScheduleCreate receipt on duplicate creation Signed-off-by: tinker-michaelj <[email protected]> * Incorporate reviewer feedback Signed-off-by: tinker-michaelj <[email protected]> * Use oneof to enforce mutual exclusion of schedule deletion and execution Signed-off-by: tinker-michaelj <[email protected]> * Use lower_snake_case for field names in oneof to ease transition to standard naming convention Signed-off-by: tinker-michaelj <[email protected]> * Redirect to ResponseCode doc section from Schedule* ops Signed-off-by: tinker-michaelj <[email protected]> * Add ThrottleDefinitions types (#23) * Create ThrottleDefinitions message Signed-off-by: tinker-michaelj <[email protected]> * Add throttle-specific response codes Signed-off-by: tinker-michaelj <[email protected]> * Add more general response codes for throttle defs Signed-off-by: tinker-michaelj <[email protected]> * Add comments to the throttle types Signed-off-by: tinker-michaelj <[email protected]> * Clarify some comments Signed-off-by: tinker-michaelj <[email protected]> * Update to milliOpsPerSec/burstPeriodMs Signed-off-by: tinker-michaelj <[email protected]> * Fix typo Signed-off-by: tinker-michaelj <[email protected]> * Be more concise Signed-off-by: tinker-michaelj <[email protected]> * Be explicit about milli-ops Signed-off-by: tinker-michaelj <[email protected]> * Emphasize only ed25519 keys are supported (#26) Signed-off-by: tinker-michaelj <[email protected]> * Revise address book types to 0.13.0 standard (#27) * Update to final version of address book messages Signed-off-by: tinker-michaelj <[email protected]> * Align with issue 750 consensus format Signed-off-by: tinker-michaelj <[email protected]> * Change ServiceEndpoint types Signed-off-by: tinker-michaelj <[email protected]> * Match comments from issue Signed-off-by: tinker-michaelj <[email protected]> * Update comment Signed-off-by: tinker-michaelj <[email protected]> * Add details Signed-off-by: tinker-michaelj <[email protected]> * Specify fallback use of deprecated fields Signed-off-by: tinker-michaelj <[email protected]> * Minor revision Signed-off-by: tinker-michaelj <[email protected]> Co-authored-by: ljianghedera <[email protected]> Co-authored-by: ljianghedera <[email protected]> * Key list (#34) * Update BasicTypes.proto * Update BasicTypes.proto * Update FileDelete.proto * Update FileCreate.proto * Update FileAppend.proto * Update FileUpdate.proto * Update BasicTypes.proto * Update FileCreate.proto * Update BasicTypes.proto * Update FileCreate.proto * Update FileUpdate.proto * Update FileAppend.proto * Update FileDelete.proto * Update BasicTypes.proto * Update BasicTypes.proto * Update BasicTypes.proto * Update BasicTypes.proto * Update BasicTypes.proto * Update FileAppend.proto * Update FileCreate.proto * Update FileDelete.proto * Update FileUpdate.proto * Update FileUpdate.proto * Update FileUpdate.proto * Update BasicTypes.proto * Update BasicTypes.proto * Update BasicTypes.proto * Update FileCreate.proto Co-authored-by: ljianghedera <[email protected]> Co-authored-by: ljianghedera <[email protected]> Co-authored-by: SimiHunjan <[email protected]> * HIP 18 (#42) * Sync to main in preparation for 0.15.0 tag (#39) * Reference node properties controlling HTS behavior Signed-off-by: tinker-michaelj <[email protected]> * Again clarify use of master Signed-off-by: tinker-michaelj <[email protected]> * Update from head of schedule-develop in hashgraph/hedera-services (#2) Signed-off-by: tinker-michaelj <[email protected]> * Standardize memos for non-schedule entities (#3) * Standardize memos for non-schedule entities Signed-off-by: tinker-michaelj <[email protected]> * Fix typo in field number Signed-off-by: tinker-michaelj <[email protected]> * Use google.protobuf.StringValue for new memo fields Signed-off-by: tinker-michaelj <[email protected]> * Comment on deprecated memoField choice Signed-off-by: tinker-michaelj <[email protected]> * Port schedule txn comments (#5) * Port schedule txn comments Signed-off-by: tinker-michaelj <[email protected]> * Add further comments Signed-off-by: tinker-michaelj <[email protected]> * Apply the same changes to hedera-protobufs repo. (#4) Signed-off-by: ljianghedera <[email protected]> Co-authored-by: ljianghedera <[email protected]> * Separate messages used for balances proto under hedera/streams (#6) * Separate messages used for balances proto under hedera/streams Signed-off-by: tinker-michaelj <[email protected]> * Restructure proto directories Signed-off-by: tinker-michaelj <[email protected]> * Change java_package for AccountBalanceFile.proto messages Signed-off-by: tinker-michaelj <[email protected]> * Extract TokenBalance(s) to BasicTypes Signed-off-by: tinker-michaelj <[email protected]> * Include decimals in queries of token/account balances and relationships (#8) Signed-off-by: tinker-michaelj <[email protected]> * Include Leemon's edits from Services issue #974 (#10) Signed-off-by: tinker-michaelj <[email protected]> * Add scheduled transaction id to TransactionReceipt + ScheduleGetInfo types (#12) * Prepare to tag 0.12.0 release (#11) * Reference node properties controlling HTS behavior Signed-off-by: tinker-michaelj <[email protected]> * Again clarify use of master Signed-off-by: tinker-michaelj <[email protected]> * Update from head of schedule-develop in hashgraph/hedera-services (#2) Signed-off-by: tinker-michaelj <[email protected]> * Standardize memos for non-schedule entities (#3) * Standardize memos for non-schedule entities Signed-off-by: tinker-michaelj <[email protected]> * Fix typo in field number Signed-off-by: tinker-michaelj <[email protected]> * Use google.protobuf.StringValue for new memo fields Signed-off-by: tinker-michaelj <[email protected]> * Comment on deprecated memoField choice Signed-off-by: tinker-michaelj <[email protected]> * Port schedule txn comments (#5) * Port schedule txn comments Signed-off-by: tinker-michaelj <[email protected]> * Add further comments Signed-off-by: tinker-michaelj <[email protected]> * Apply the same changes to hedera-protobufs repo. (#4) Signed-off-by: ljianghedera <[email protected]> Co-authored-by: ljianghedera <[email protected]> * Separate messages used for balances proto under hedera/streams (#6) * Separate messages used for balances proto under hedera/streams Signed-off-by: tinker-michaelj <[email protected]> * Restructure proto directories Signed-off-by: tinker-michaelj <[email protected]> * Change java_package for AccountBalanceFile.proto messages Signed-off-by: tinker-michaelj <[email protected]> * Extract TokenBalance(s) to BasicTypes Signed-off-by: tinker-michaelj <[email protected]> * Include decimals in queries of token/account balances and relationships (#8) Signed-off-by: tinker-michaelj <[email protected]> * Include Leemon's edits from Services issue #974 (#10) Signed-off-by: tinker-michaelj <[email protected]> Co-authored-by: ljianghedera <[email protected]> * Update README.md * Add scheduledTransactionID fields to TransactionReceipt and ScheduleGetInfo Signed-off-by: tinker-michaelj <[email protected]> * Update README Signed-off-by: tinker-michaelj <[email protected]> Co-authored-by: ljianghedera <[email protected]> * 00017 d hcs message size (#19) * Add response code for Hcs message size limit. Signed-off-by: ljianghedera <[email protected]> * Add the response code for HCS message too large. Signed-off-by: ljianghedera <[email protected]> * Update protobufs to satisfy revised scheduled txns spec (#15) * Update protobufs to satisfy revised scheduled txns spec Signed-off-by: tinker-michaelj <[email protected]> * Improve comment readability Signed-off-by: tinker-michaelj <[email protected]> * Make explicit mention of scheduling.whitelist Signed-off-by: tinker-michaelj <[email protected]> * Incorporate reviewer feedback Signed-off-by: tinker-michaelj <[email protected]> * Standardize on payerAccountID Signed-off-by: tinker-michaelj <[email protected]> * Add scheduledTransactionID to ScheduleInfo Signed-off-by: tinker-michaelj <[email protected]> * Clarify effects of schedule deletion Signed-off-by: tinker-michaelj <[email protected]> * Include expiration time in getScheduleInfo response Signed-off-by: tinker-michaelj <[email protected]> * Change now-obsolete UNPARSEABLE_SCHEDULED_TRANSACTION response code to SCHEDULED_TRANSACTION_NOT_IN_WHITELIST; remove UNSCHEDULABLE_TRANSACTION Signed-off-by: tinker-michaelj <[email protected]> * Remove unneeded imports Signed-off-by: tinker-michaelj <[email protected]> * Replace deleted/executed flags with consensus timestamps Signed-off-by: tinker-michaelj <[email protected]> * Update info on ScheduleCreate receipt on duplicate creation Signed-off-by: tinker-michaelj <[email protected]> * Incorporate reviewer feedback Signed-off-by: tinker-michaelj <[email protected]> * Use oneof to enforce mutual exclusion of schedule deletion and execution Signed-off-by: tinker-michaelj <[email protected]> * Use lower_snake_case for field names in oneof to ease transition to standard naming convention Signed-off-by: tinker-michaelj <[email protected]> * Redirect to ResponseCode doc section from Schedule* ops Signed-off-by: tinker-michaelj <[email protected]> * Add ThrottleDefinitions types (#23) * Create ThrottleDefinitions message Signed-off-by: tinker-michaelj <[email protected]> * Add throttle-specific response codes Signed-off-by: tinker-michaelj <[email protected]> * Add more general response codes for throttle defs Signed-off-by: tinker-michaelj <[email protected]> * Add comments to the throttle types Signed-off-by: tinker-michaelj <[email protected]> * Clarify some comments Signed-off-by: tinker-michaelj <[email protected]> * Update to milliOpsPerSec/burstPeriodMs Signed-off-by: tinker-michaelj <[email protected]> * Fix typo Signed-off-by: tinker-michaelj <[email protected]> * Be more concise Signed-off-by: tinker-michaelj <[email protected]> * Be explicit about milli-ops Signed-off-by: tinker-michaelj <[email protected]> * Emphasize only ed25519 keys are supported (#26) Signed-off-by: tinker-michaelj <[email protected]> * Revise address book types to 0.13.0 standard (#27) * Update to final version of address book messages Signed-off-by: tinker-michaelj <[email protected]> * Align with issue 750 consensus format Signed-off-by: tinker-michaelj <[email protected]> * Change ServiceEndpoint types Signed-off-by: tinker-michaelj <[email protected]> * Match comments from issue Signed-off-by: tinker-michaelj <[email protected]> * Update comment Signed-off-by: tinker-michaelj <[email protected]> * Add details Signed-off-by: tinker-michaelj <[email protected]> * Specify fallback use of deprecated fields Signed-off-by: tinker-michaelj <[email protected]> * Minor revision Signed-off-by: tinker-michaelj <[email protected]> * Add full semver meta to SemanticVersion (#33) * Add full semver meta to SemanticVersion Signed-off-by: tinker-michaelj <[email protected]> * Add top-level comment on SemanticVersion Signed-off-by: tinker-michaelj <[email protected]> * Abbreviate SemanticVersion optional fields Signed-off-by: tinker-michaelj <[email protected]> * Add ACCOUNT_EXPIRED_AND_PENDING_REMOVAL response code (#35) Signed-off-by: tinker-michaelj <[email protected]> * Feature: NFT Tokens (#37) * feat(tokens): nfts Signed-off-by: failfmi <[email protected]> * feat: multiple fee data per hedera functionality; sub type distinguishing different fee data Signed-off-by: failfmi <[email protected]> * deprecate feedata property Signed-off-by: Daniel Ivanov <[email protected]> * style: rename repeated fee data field Signed-off-by: failfmi <[email protected]> * Error ResponseCodes Signed-off-by: Georgi Yazovaliyski <[email protected]> Co-authored-by: Daniel Ivanov <[email protected]> Co-authored-by: Georgi Yazovaliyski <[email protected]> * Sync develop with main (#38) * Prepare for 0.13.0 tag (#28) * Reference node properties controlling HTS behavior Signed-off-by: tinker-michaelj <[email protected]> * Again clarify use of master Signed-off-by: tinker-michaelj <[email protected]> * Update from head of schedule-develop in hashgraph/hedera-services (#2) Signed-off-by: tinker-michaelj <[email protected]> * Standardize memos for non-schedule entities (#3) * Standardize memos for non-schedule entities Signed-off-by: tinker-michaelj <[email protected]> * Fix typo in field number Signed-off-by: tinker-michaelj <[email protected]> * Use google.protobuf.StringValue for new memo fields Signed-off-by: tinker-michaelj <[email protected]> * Comment on deprecated memoField choice Signed-off-by: tinker-michaelj <[email protected]> * Port schedule txn comments (#5) * Port schedule txn comments Signed-off-by: tinker-michaelj <[email protected]> * Add further comments Signed-off-by: tinker-michaelj <[email protected]> * Apply the same changes to hedera-protobufs repo. (#4) Signed-off-by: ljianghedera <[email protected]> Co-authored-by: ljianghedera <[email protected]> * Separate messages used for balances proto under hedera/streams (#6) * Separate messages used for balances proto under hedera/streams Signed-off-by: tinker-michaelj <[email protected]> * Restructure proto directories Signed-off-by: tinker-michaelj <[email protected]> * Change java_package for AccountBalanceFile.proto messages Signed-off-by: tinker-michaelj <[email protected]> * Extract TokenBalance(s) to BasicTypes Signed-off-by: tinker-michaelj <[email protected]> * Include decimals in queries of token/account balances and relationships (#8) Signed-off-by: tinker-michaelj <[email protected]> * Include Leemon's edits from Services issue #974 (#10) Signed-off-by: tinker-michaelj <[email protected]> * Add scheduled transaction id to TransactionReceipt + ScheduleGetInfo types (#12) * Prepare to tag 0.12.0 release (#11) * Reference node properties controlling HTS behavior Signed-off-by: tinker-michaelj <[email protected]> * Again clarify use of master Signed-off-by: tinker-michaelj <[email protected]> * Update from head of schedule-develop in hashgraph/hedera-services (#2) Signed-off-by: tinker-michaelj <[email protected]> * Standardize memos for non-schedule entities (#3) * Standardize memos for non-schedule entities Signed-off-by: tinker-michaelj <[email protected]> * Fix typo in field number Signed-off-by: tinker-michaelj <[email protected]> * Use google.protobuf.StringValue for new memo fields Signed-off-by: tinker-michaelj <[email protected]> * Comment on deprecated memoField choice Signed-off-by: tinker-michaelj <[email protected]> * Port schedule txn comments (#5) * Port schedule txn comments Signed-off-by: tinker-michaelj <[email protected]> * Add further comments Signed-off-by: tinker-michaelj <[email protected]> * Apply the same changes to hedera-protobufs repo. (#4) Signed-off-by: ljianghedera <[email protected]> Co-authored-by: ljianghedera <[email protected]> * Separate messages used for balances proto under hedera/streams (#6) * Separate messages used for balances proto under hedera/streams Signed-off-by: tinker-michaelj <[email protected]> * Restructure proto directories Signed-off-by: tinker-michaelj <[email protected]> * Change java_package for AccountBalanceFile.proto messages Signed-off-by: tinker-michaelj <[email protected]> * Extract TokenBalance(s) to BasicTypes Signed-off-by: tinker-michaelj <[email protected]> * Include decimals in queries of token/account balances and relationships (#8) Signed-off-by: tinker-michaelj <[email protected]> * Include Leemon's edits from Services issue #974 (#10) Signed-off-by: tinker-michaelj <[email protected]> Co-authored-by: ljianghedera <[email protected]> * Update README.md * Add scheduledTransactionID fields to TransactionReceipt and ScheduleGetInfo Signed-off-by: tinker-michaelj <[email protected]> * Update README Signed-off-by: tinker-michaelj <[email protected]> Co-authored-by: ljianghedera <[email protected]> * 00017 d hcs message size (#19) * Add response code for Hcs message size limit. Signed-off-by: ljianghedera <[email protected]> * Add the response code for HCS message too large. Signed-off-by: ljianghedera <[email protected]> * Update protobufs to satisfy revised scheduled txns spec (#15) * Update protobufs to satisfy revised scheduled txns spec Signed-off-by: tinker-michaelj <[email protected]> * Improve comment readability Signed-off-by: tinker-michaelj <[email protected]> * Make explicit mention of scheduling.whitelist Signed-off-by: tinker-michaelj <[email protected]> * Incorporate reviewer feedback Signed-off-by: tinker-michaelj <[email protected]> * Standardize on payerAccountID Signed-off-by: tinker-michaelj <[email protected]> * Add scheduledTransactionID to ScheduleInfo Signed-off-by: tinker-michaelj <[email protected]> * Clarify effects of schedule deletion Signed-off-by: tinker-michaelj <[email protected]> * Include expiration time in getScheduleInfo response Signed-off-by: tinker-michaelj <[email protected]> * Change now-obsolete UNPARSEABLE_SCHEDULED_TRANSACTION response code to SCHEDULED_TRANSACTION_NOT_IN_WHITELIST; remove UNSCHEDULABLE_TRANSACTION Signed-off-by: tinker-michaelj <[email protected]> * Remove unneeded imports Signed-off-by: tinker-michaelj <[email protected]> * Replace deleted/executed flags with consensus timestamps Signed-off-by: tinker-michaelj <[email protected]> * Update info on ScheduleCreate receipt on duplicate creation Signed-off-by: tinker-michaelj <[email protected]> * Incorporate reviewer feedback Signed-off-by: tinker-michaelj <[email protected]> * Use oneof to enforce mutual exclusion of schedule deletion and execution Signed-off-by: tinker-michaelj <[email protected]> * Use lower_snake_case for field names in oneof to ease transition to standard naming convention Signed-off-by: tinker-michaelj <[email protected]> * Redirect to ResponseCode doc section from Schedule* ops Signed-off-by: tinker-michaelj <[email protected]> * Add ThrottleDefinitions types (#23) * Create ThrottleDefinitions message Signed-off-by: tinker-michaelj <[email protected]> * Add throttle-specific response codes Signed-off-by: tinker-michaelj <[email protected]> * Add more general response codes for throttle defs Signed-off-by: tinker-michaelj <[email protected]> * Add comments to the throttle types Signed-off-by: tinker-michaelj <[email protected]> * Clarify some comments Signed-off-by: tinker-michaelj <[email protected]> * Update to milliOpsPerSec/burstPeriodMs Signed-off-by: tinker-michaelj <[email protected]> * Fix typo Signed-off-by: tinker-michaelj <[email protected]> * Be more concise Signed-off-by: tinker-michaelj <[email protected]> * Be explicit about milli-ops Signed-off-by: tinker-michaelj <[email protected]> * Emphasize only ed25519 keys are supported (#26) Signed-off-by: tinker-michaelj <[email protected]> * Revise address book types to 0.13.0 standard (#27) * Update to final version of address book messages Signed-off-by: tinker-michaelj <[email protected]> * Align with issue 750 consensus format Signed-off-by: tinker-michaelj <[email protected]> * Change ServiceEndpoint types Signed-off-by: tinker-michaelj <[email protected]> * Match comments from issue Signed-off-by: tinker-michaelj <[email protected]> * Update comment Signed-off-by: tinker-michaelj <[email protected]> * Add details Signed-off-by: tinker-michaelj <[email protected]> * Specify fallback use of deprecated fields Signed-off-by: tinker-michaelj <[email protected]> * Minor revision Signed-off-by: tinker-michaelj <[email protected]> Co-authored-by: ljianghedera <[email protected]> Co-authored-by: ljianghedera <[email protected]> * Key list (#34) * Update BasicTypes.proto * Update BasicTypes.proto * Update FileDelete.proto * Update FileCreate.proto * Update FileAppend.proto * Update FileUpdate.proto * Update BasicTypes.proto * Update FileCreate.proto * Update BasicTypes.proto * Update FileCreate.proto * Update FileUpdate.proto * Update FileAppend.proto * Update FileDelete.proto * Update BasicTypes.proto * Update BasicTypes.proto * Update BasicTypes.proto * Update BasicTypes.proto * Update BasicTypes.proto * Update FileAppend.proto * Update FileCreate.proto * Update FileDelete.proto * Update FileUpdate.proto * Update FileUpdate.proto * Update FileUpdate.proto * Update BasicTypes.proto * Update BasicTypes.proto * Update BasicTypes.proto * Update FileCreate.proto Co-authored-by: ljianghedera <[email protected]> Co-authored-by: ljianghedera <[email protected]> Co-authored-by: SimiHunjan <[email protected]> Co-authored-by: ljianghedera <[email protected]> Co-authored-by: ljianghedera <[email protected]> Co-authored-by: failfmi <[email protected]> Co-authored-by: Daniel Ivanov <[email protected]> Co-authored-by: Georgi Yazovaliyski <[email protected]> Co-authored-by: SimiHunjan <[email protected]> * added messages for custom token fee type and custom hbar fee type Signed-off-by: anighanta <[email protected]> * 041- add response code RECEIVER_SIG_REQUIRED Signed-off-by: anighanta <[email protected]> * add a Fraction type to denote percentages more elegently Signed-off-by: anighanta <[email protected]> * typo fix Signed-off-by: anighanta <[email protected]> * Encapsulate TokenFee and HbarFee in a single message Signed-off-by: anighanta <[email protected]> * Define fixed and fractional fee to avoid illegal combinations Signed-off-by: anighanta <[email protected]> * fix typo Signed-off-by: anighanta <[email protected]> * add missing import and typo fix Signed-off-by: anighanta <[email protected]> * added description to the the fields and renamed recevingAccountId to feeCollector Signed-off-by: anighanta <[email protected]> * Splitting the CustomFees out in a separate class. Signed-off-by: Quan Nguyen <[email protected]> * Consolidate all the CustomFees into one type of message for using in report as well. Signed-off-by: Quan Nguyen <[email protected]> * Add some comments and the CustomFeeCharged message + imports Signed-off-by: tinker-michaelj <[email protected]> * added customFeesKey to TokenCreate, TokenGetInfo, TokenUpdate Signed-off-by: abhishek-hedera <[email protected]> * add a few ResponseCodes Signed-off-by: Neeharika-Sompalli <[email protected]> * Added missing comments for CryptoTransfer message. Signed-off-by: ljianghedera <[email protected]> * Add TOKEN_MAX_SUPPLY_REACHED Signed-off-by: tinker-michaelj <[email protected]> * Add SENDER_DOES_NOT_OWN_NFT_SERIAL_NO Signed-off-by: tinker-michaelj <[email protected]> * Include CUSTOM_FEE_NOT_FULLY_SPECIFIED Signed-off-by: tinker-michaelj <[email protected]> * Add INVALID_CUSTOM_FEE_KEY and TOKEN_HAS_NO_CUSTOM_FEE_KEY Signed-off-by: tinker-michaelj <[email protected]> * Address reviewer comments Signed-off-by: tinker-michaelj <[email protected]> * Reduce wordiness Signed-off-by: tinker-michaelj <[email protected]> * Reduce wordiness Signed-off-by: tinker-michaelj <[email protected]> * Clean up wording Signed-off-by: tinker-michaelj <[email protected]> * Remove unneeded import Signed-off-by: tinker-michaelj <[email protected]> * Clean up wording Signed-off-by: tinker-michaelj <[email protected]> * Fix TokenGetInfo Signed-off-by: tinker-michaelj <[email protected]> * Remove custom fee key response codes Signed-off-by: tinker-michaelj <[email protected]> * Tweak response code names Signed-off-by: tinker-michaelj <[email protected]> * Change all sint64 to int64 Signed-off-by: tinker-michaelj <[email protected]> * Add CUSTOM_FEE_OUTSIDE_NUMERIC_RANGE Signed-off-by: tinker-michaelj <[email protected]> * Clarify custom_fees in TokenUpdate. Add INVALID_CUSTOM_FRACTIONAL_FEES_SUM response code. Signed-off-by: Quan Nguyen <[email protected]> Co-authored-by: Michael Tinker <[email protected]> Co-authored-by: ljianghedera <[email protected]> Co-authored-by: ljianghedera <[email protected]> Co-authored-by: failfmi <[email protected]> Co-authored-by: Daniel Ivanov <[email protected]> Co-authored-by: Georgi Yazovaliyski <[email protected]> Co-authored-by: SimiHunjan <[email protected]> Co-authored-by: Quan Nguyen <[email protected]> Co-authored-by: abhishek-hedera <[email protected]> Co-authored-by: Neeharika-Sompalli <[email protected]> * re-add deprecated fields to Transaction (#29) previously deprecated fields are still needed to be able to historically parse valid transactions * HIP-18 add missing response code (#46) * add FRACTIONAL_FEES_MIN_AMOUNT_GREATER_THAN_MAX_AMOUNT Signed-off-by: Neeharika-Sompalli <[email protected]> * fix typo Signed-off-by: Neeharika-Sompalli <[email protected]> * Suggested wording. Signed-off-by: Quan Nguyen <[email protected]> Co-authored-by: Quan Nguyen <[email protected]> * Rename TokenGetAccountNftInfo + add new Response code (#44) * feat(tokens): nfts Signed-off-by: failfmi <[email protected]> * feat: multiple fee data per hedera functionality; sub type distinguishing different fee data Signed-off-by: failfmi <[email protected]> * deprecate feedata property Signed-off-by: Daniel Ivanov <[email protected]> * style: rename repeated fee data field Signed-off-by: failfmi <[email protected]> * Error ResponseCodes Signed-off-by: Georgi Yazovaliyski <[email protected]> * Modifications Catch Up Signed-off-by: Georgi Yazovaliyski <[email protected]> * Documentation Modification Signed-off-by: Georgi Yazovaliyski <[email protected]> * revert unnecessary changes Signed-off-by: Daniel Ivanov <[email protected]> * remove leftover file Signed-off-by: Daniel Ivanov <[email protected]> * resolve conflicts Signed-off-by: Daniel Ivanov <[email protected]> * Property renaming Signed-off-by: Georgi Yazovaliyski <[email protected]> Co-authored-by: failfmi <[email protected]> Co-authored-by: Georgi Yazovaliyski <[email protected]> * Add TokenFeeScheduleUpdate op to allow switch back to fee_schedule_key (#47) * Add TokenFeeScheduleUpdate op to allow switch back to fee_schedule_key Signed-off-by: tinker-michaelj <[email protected]> * Add missing file Signed-off-by: tinker-michaelj <[email protected]> * Reviewer comments Signed-off-by: tinker-michaelj <[email protected]> * Snakecase Signed-off-by: tinker-michaelj <[email protected]> * Add more responseCodes (#49) * added response codes for if we a denominatig token type is a NFT and one for when and NFT has a fractional fee in its feeSchedule Signed-off-by: anighanta <[email protected]> * Add response code for invalid fee schedule key. Signed-off-by: ljianghedera <[email protected]> * Renamed the token fee schedule key respond code name. Signed-off-by: ljianghedera <[email protected]> * Standardize comments in new response codes Signed-off-by: tinker-michaelj <[email protected]> Co-authored-by: ljianghedera <[email protected]> Co-authored-by: tinker-michaelj <[email protected]> * Include three response codes for v0.16.0-alpha.1 tag (#52) Signed-off-by: tinker-michaelj <[email protected]> * Response codes for previewnet bugs (#54) * Add ACCOUNT_STILL_OWNS_NFTS and TREASURY_MUST_OWN_BURNED_NFT Signed-off-by: tinker-michaelj <[email protected]> * Add ACCOUNT_DOES_NOT_OWN_WIPED_NFT and TOKEN_TRANSFERS_LIST_ONLY_USABLE_WITH_FUNGIBLE_COMMON Signed-off-by: tinker-michaelj <[email protected]> * Rename TOKEN_TRANSFERS_LIST_ONLY_USABLE_WITH_FUNGIBLE_COMMON to be more accurate Signed-off-by: tinker-michaelj <[email protected]> * fixed typo (#55) Signed-off-by: SimiHunjan <[email protected]> * Nfts: Documentation Update (#53) * Sync to main in preparation for 0.15.0 tag (#39) * Reference node properties controlling HTS behavior Signed-off-by: tinker-michaelj <[email protected]> * Again clarify use of master Signed-off-by: tinker-michaelj <[email protected]> * Update from head of schedule-develop in hashgraph/hedera-services (#2) Signed-off-by: tinker-michaelj <[email protected]> * Standardize memos for non-schedule entities (#3) * Standardize memos for non-schedule entities Signed-off-by: tinker-michaelj <[email protected]> * Fix typo in field number Signed-off-by: tinker-michaelj <[email protected]> * Use google.protobuf.StringValue for new memo fields Signed-off-by: tinker-michaelj <[email protected]> * Comment on deprecated memoField choice Signed-off-by: tinker-michaelj <[email protected]> * Port schedule txn comments (#5) * Port schedule txn comments Signed-off-by: tinker-michaelj <[email protected]> * Add further comments Signed-off-by: tinker-michaelj <[email protected]> * Apply the same changes to hedera-protobufs repo. (#4) Signed-off-by: ljianghedera <[email protected]> Co-authored-by: ljianghedera <[email protected]> * Separate messages used for balances proto under hedera/streams (#6) * Separate messages used for balances proto under hedera/streams Signed-off-by: tinker-michaelj <[email protected]> * Restructure proto directories Signed-off-by: tinker-michaelj <[email protected]> * Change java_package for AccountBalanceFile.proto messages Signed-off-by: tinker-michaelj <[email protected]> * Extract TokenBalance(s) to BasicTypes Signed-off-by: tinker-michaelj <[email protected]> * Include decimals in queries of token/account balances and relationships (#8) Signed-off-by: tinker-michaelj <[email protected]> * Include Leemon's edits from Services issue #974 (#10) Signed-off-by: tinker-michaelj <[email protected]> * Add scheduled transaction id to TransactionReceipt + ScheduleGetInfo types (#12) * Prepare to tag 0.12.0 release (#11) * Reference node properties controlling HTS behavior Signed-off-by: tinker-michaelj <[email protected]> * Again clarify use of master Signed-off-by: tinker-michaelj <[email protected]> * Update from head of schedule-develop in hashgraph/hedera-services (#2) Signed-off-by: tinker-michaelj <[email protected]> * Standardize memos for non-schedule entities (#3) * Standardize memos for non-schedule entities Signed-off-by: tinker-michaelj <[email protected]> * Fix typo in field number Signed-off-by: tinker-michaelj <[email protected]> * Use google.protobuf.StringValue for new memo fields Signed-off-by: tinker-michaelj <[email protected]> * Comment on deprecated memoField choice Signed-off-by: tinker-michaelj <[email protected]> * Port schedule txn comments (#5) * Port schedule txn comments Signed-off-by: tinker-michaelj <[email protected]> * Add further comments Signed-off-by: tinker-michaelj <[email protected]> * Apply the same changes to hedera-protobufs repo. (#4) Signed-off-by: ljianghedera <[email protected]> Co-authored-by: ljianghedera <[email protected]> * Separate messages used for balances proto under hedera/streams (#6) * Separate messages used for balances proto under hedera/streams Signed-off-by: tinker-michaelj <[email protected]> * Restructure proto directories Signed-off-by: tinker-michaelj <[email protected]> * Change java_package for AccountBalanceFile.proto messages Signed-off-by: tinker-michaelj <[email protected]> * Extract TokenBalance(s) to BasicTypes Signed-off-by: tinker-michaelj <[email protected]> * Include decimals in queries of token/account balances and relationships (#8) Signed-off-by: tinker-michaelj <[email protected]> * Include Leemon's edits from Services issue #974 (#10) Signed-off-by: tinker-michaelj <[email protected]> Co-authored-by: ljianghedera <[email protected]> * Update README.md * Add scheduledTransactionID fields to TransactionReceipt and ScheduleGetInfo Signed-off-by: tinker-michaelj <[email protected]> * Update README Signed-off-by: tinker-michaelj <[email protected]> Co-authored-by: ljianghedera <[email protected]> * 00017 d hcs message size (#19) * Add response code for Hcs message size limit. Signed-off-by: ljianghedera <[email protected]> * Add the response code for HCS message too large. Signed-off-by: ljianghedera <[email protected]> * Update protobufs to satisfy revised scheduled txns spec (#15) * Update protobufs to satisfy revised scheduled txns spec Signed-off-by: tinker-michaelj <[email protected]> * Improve comment readability Signed-off-by: tinker-michaelj <[email protected]> * Make explicit mention of scheduling.whitelist Signed-off-by: tinker-michaelj <[email protected]> * Incorporate reviewer feedback Signed-off-by: tinker-michaelj <[email protected]> * Standardize on payerAccountID Signed-off-by: tinker-michaelj <[email protected]> * Add scheduledTransactionID to ScheduleInfo Signed-off-by: tinker-michaelj <[email protected]> * Clarify effects of schedule deletion Signed-off-by: tinker-michaelj <[email protected]> * Include expiration time in getScheduleInfo response Signed-off-by: tinker-michaelj <[email protected]> * Change now-obsolete UNPARSEABLE_SCHEDULED_TRANSACTION response code to SCHEDULED_TRANSACTION_NOT_IN_WHITELIST; remove UNSCHEDULABLE_TRANSACTION Signed-off-by: tinker-michaelj <[email protected]> * Remove unneeded imports Signed-off-by: tinker-michaelj <[email protected]> * Replace deleted/executed flags with consensus timestamps Signed-off-by: tinker-michaelj <[email protected]> * Update info on ScheduleCreate receipt on duplicate creation Signed-off-by: tinker-michaelj <[email protected]> * Incorporate reviewer feedback Signed-off-by: tinker-michaelj <[email protected]> * Use oneof to enforce mutual exclusion of schedule deletion and execution Signed-off-by: tinker-michaelj <[email protected]> * Use lower_snake_case for field names in oneof to ease transition to standard naming convention Signed-off-by: tinker-michaelj <[email protected]> * Redirect to ResponseCode doc section from Schedule* ops Signed-off-by: tinker-michaelj <[email protected]> * Add ThrottleDefinitions types (#23) * Create ThrottleDefinitions message Signed-off-by: tinker-michaelj <[email protected]> * Add throttle-specific response codes Signed-off-by: tinker-michaelj <[email protected]> * Add more general response codes for throttle defs Signed-off-by: tinker-michaelj <[email protected]> * Add comments to the throttle types Signed-off-by: tinker-michaelj <[email protected]> * Clarify some comments Signed-off-by: tinker-michaelj <[email protected]> * Update to milliOpsPerSec/burstPeriodMs Signed-off-by: tinker-michaelj <[email protected]> * Fix typo Signed-off-by: tinker-michaelj <[email protected]> * Be more concise Signed-off-by: tinker-michaelj <[email protected]> * Be explicit about milli-ops Signed-off-by: tinker-michaelj <[email protected]> * Emphasize only ed25519 keys are supported (#26) Signed-off-by: tinker-michaelj <[email protected]> * Revise address book types to 0.13.0 standard (#27) * Update to final version of address book messages Signed-off-by: tinker-michaelj <[email protected]> * Align with issue 750 consensus format Signed-off-by: tinker-michaelj <[email protected]> * Change ServiceEndpoint types Signed-off-by: tinker-michaelj <[email protected]> * Match comments from issue Signed-off-by: tinker-michaelj <[email protected]> * Update comment Signed-off-by: tinker-michaelj <[email protected]> * Add details Signed-off-by: tinker-michaelj <[email protected]> * Specify fallback use of deprecated fields Signed-off-by: tinker-michaelj <[email protected]> * Minor revision Signed-off-by: tinker-michaelj <[email protected]> * Add full semver meta to SemanticVersion (#33) * Add full semver meta to SemanticVersion Signed-off-by: tinker-michaelj <[email protected]> * Add top-level comment on SemanticVersion Signed-off-by: tinker-michaelj <[email protected]> * Abbreviate SemanticVersion optional fields Signed-off-by: tinker-michaelj <[email protected]> * Add ACCOUNT_EXPIRED_AND_PENDING_REMOVAL response code (#35) Signed-off-by: tinker-michaelj <[email protected]> * Feature: NFT Tokens (#37) * feat(tokens): nfts Signed-off-by: failfmi <[email protected]> * feat: multiple fee data per hedera functionality; sub type distinguishing different fee data Signed-off-by: failfmi <[email protected]> * deprecate feedata property Signed-off-by: Daniel Ivanov <[email protected]> * style: rename repeated fee data field Signed-off-by: failfmi <[email protected]> * Error ResponseCodes Signed-off-by: Georgi Yazovaliyski <[email protected]> Co-authored-by: Daniel Ivanov <[email protected]> Co-authored-by: Georgi Yazovaliyski <[email protected]> * Sync develop with main (#38) * Prepare for 0.13.0 tag (#28) * Reference node properties controlling HTS behavior Signed-off-by: tinker-michaelj <[email protected]> * Again clarify use of master Signed-off-by: tinker-michaelj <[email protected]> * Update from head of schedule-develop in hashgraph/hedera-services (#2) Signed-off-by: tinker-michaelj <[email protected]> * Standardize memos for non-schedule entities (#3) * Standardize memos for non-schedule entities Signed-off-by: tinker-michaelj <[email protected]> * Fix typo in field number Signed-off-by: tinker-michaelj <[email protected]> * Use google.protobuf.StringValue for new memo fields Signed-off-by: tinker-michaelj <[email protected]> * Comment on deprecated memoField choice Signed-off-by: tinker-michaelj <[email protected]> * Port schedule txn comments (#5) * Port schedule txn comments Signed-off-by: tinker-michaelj <[email protected]> * Add further comments Signed-off-by: tinker-michaelj <[email protected]> * Apply the same changes to hedera-protobufs repo. (#4) Signed-off-by: ljianghedera <[email protected]> Co-authored-by: ljianghedera <[email protected]> * Separate messages used for balances proto under hedera/streams (#6) * Separate messages used for balances proto under hedera/streams Signed-off-by: tinker-michaelj <[email protected]> * Restructure proto directories Signed-off-by: tinker-michaelj <[email protected]> * Change java_package for AccountBalanceFile.proto messages Signed-off-by: tinker-michaelj <[email protected]> * Extract TokenBalance(s) to BasicTypes Signed-off-by: tinker-michaelj <[email protected]> * Include decimals in queries of token/account balances and relationships (#8) Signed-off-by: tinker-michaelj <[email protected]> * Include Leemon's edits from Services issue #974 (#10) Signed-off-by: tinker-michaelj <[email protected]> * Add scheduled transaction id to TransactionReceipt + ScheduleGetInfo types (#12) * Prepare to tag 0.12.0 release (#11) * Reference node properties controlling HTS behavior Signed-off-by: tinker-michaelj <[email protected]> * Again clarify use of master Signed-off-by: tinker-michaelj <[email protected]> * Update from head of schedule-develop in hashgraph/hedera-services (#2) Signed-off-by: tinker-michaelj <[email protected]> * Standardize memos for non-schedule entities (#3) * Standardize memos for non-schedule entities Signed-off-by: tinker-michaelj <[email protected]> * Fix typo in field number Signed-off-by: tinker-michaelj <[email protected]> * Use google.protobuf.StringValue for new memo fields Signed-off-by: tinker-michaelj <[email protected]> * Comment on deprecated memoField choice Signed-off-by: tinker-michaelj <[email protected]> * Port schedule txn comments (#5) * Port schedule txn comments Signed-off-by: tinker-michaelj <[email protected]> * Add further comments Signed-off-by: tinker-michaelj <[email protected]> * Apply the same changes to hedera-protobufs repo. (#4) Signed-off-by: ljianghedera <[email protected]> Co-authored-by: ljianghedera <[email protected]> * Separate messages used for balances proto under hedera/streams (#6) * Separate messages used for balances proto under hedera/streams Signed-off-by: tinker-michaelj <[email protected]> * Restructure proto directories Signed-off-by: tinker-michaelj <[email protected]> * Change java_package for AccountBalanceFile.proto messages Signed-off-by: tinker-michaelj <[email protected]> * Extract TokenBalance(s) to BasicTypes Signed-off-by: tinker-michaelj <[email protected]> * Include decimals in queries of token/account balances and relationships (#8) Signed-off-by: tinker-michaelj <[email protected]> * Include Leemon's edits from Services issue #974 (#10) Signed-off-by: tinker-michaelj <[email protected]> Co-authored-by: ljianghedera <[email protected]> * Update README.md * Add scheduledTransactionID fields to TransactionReceipt and ScheduleGetInfo Signed-off-by: tinker-michaelj <[email protected]> * Update README Signed-off-by: tinker-michaelj <[email protected]> Co-authored-by: ljianghedera <[email protected]> * 00017 d hcs message size (#19) * Add response code for Hcs message size limit. Signed-off-by: ljianghedera <[email protected]> * Add the response code for HCS message too large. Signed-off-by: ljianghedera <[email protected]> * Update protobufs to satisfy revised scheduled txns spec (#15) * Update protobufs to satisfy revised scheduled txns spec Signed-off-by: tinker-michaelj <[email protected]> * Improve comment readability Signed-off-by: tinker-michaelj <[email protected]> * Make explicit mention of scheduling.whitelist Signed-off-by: tinker-michaelj <[email protected]> * Incorporate reviewer feedback Signed-off-by: tinker-michaelj <[email protected]> * Standardize on payerAccountID Signed-off-by: tinker-michaelj <[email protected]> * Add scheduledTransactionID to ScheduleInfo Signed-off-by: tinker-michaelj <[email protected]> * Clarify effects of schedule deletion Signed-off-by: tinker-michaelj <[email protected]> * Include expiration time in getScheduleInfo response Signed-off-by: tinker-michaelj <[email protected]> * Change now-obsolete UNPARSEABLE_SCHEDULED_TRANSACTION response code to SCHEDULED_TRANSACTION_NOT_IN_WHITELIST; remove UNSCHEDULABLE_TRANSACTION Signed-off-by: tinker-michaelj <[email protected]> * Remove unneeded imports Signed-off-by: tinker-michaelj <[email protected]> * Replace deleted/executed flags with consensus timestamps Signed-off-by: tinker-michaelj <[email protected]> * Update info on ScheduleCreate receipt on duplicate creation Signed-off-by: tinker-michaelj <[email protected]> * Incorporate reviewer feedback Signed-off-by: tinker-michaelj <[email protected]> * Use oneof to enforce mutual exclusion of schedule deletion and execution Signed-off-by: tinker-michaelj <[email protected]> * Use lower_snake_case for field names in oneof to ease transition to standard naming convention Signed-off-by: tinker-michaelj <[email protected]> * Redirect to ResponseCode doc section from Schedule* ops Signed-off-by: tinker-michaelj <[email protected]> * Add ThrottleDefinitions types (#23) * Create ThrottleDefinitions message Signed-off-by: tinker-michaelj <[email protected]> * Add throttle-specific response codes Signed-off-by: tinker-michaelj <[email protected]> * Add more general response codes for throttle defs Signed-off-by: tinker-michaelj <[email protected]> * Add comments to the throttle types Signed-off-by: tinker-michaelj <[email protected]> * Clarify some comments Signed-off-by: tinker-michaelj <[email protected]> * Update to milliOpsPerSec/burstPeriodMs Signed-off-by: tinker-michaelj <[email protected]> * Fix typo Signed-off-by: tinker-michaelj <[email protected]> * Be more concise Signed-off-by: tinker-michaelj <[email protected]> * Be explicit about milli-ops Signed-off-by: tinker-michaelj <[email protected]> * Emphasize only ed25519 keys are supported (#26) Signed-off-by: tinker-michaelj <[email protected]> * Revise address book types to 0.13.0 standard (#27) * Update to final version of address book messages Signed-off-by: tinker-michaelj <[email protected]> * Align with issue 750 consensus format Signed-off-by: tinker-michaelj <[email protected]> * Change ServiceEndpoint types Signed-off-by: tinker-michaelj <[email protected]> * Match comments from issue Signed-off-by: tinker-michaelj <[email protected]> * Update comment Signed-off-by: tinker-michaelj <[email protected]> * Add details Signed-off-by: tinker-michaelj <michael.ti…
Signed-off-by: SimiHunjan <[email protected]>
qnswirlds
approved these changes
Dec 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Needs to resolve conflicts though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: SimiHunjan [email protected]
Description:
Remove incorrect comment
Related issue(s):
Fixes #
Notes for reviewer:
Checklist