Replace use of deprecated DirectProcessor #9630
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution. Can you please signoff your commits using DCO? |
saai-syvendra
force-pushed
the
5187-deprecated-DirectProcessor
branch
from
c7267f9
to
26d17fa
Compare
|
Hi @steven-sheehy! Hope its okay now |
steven-sheehy
added
enhancement
xin-hedera
requested changes
Oct 30, 2024
hedera-mirror-grpc/src/main/java/com/hedera/mirror/grpc/listener/SharedTopicListener.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Saai Syvendra (Github key) <[email protected]>
Signed-off-by: Saai Syvendra (Github key) <[email protected]>
saai-syvendra
force-pushed
the
5187-deprecated-DirectProcessor
branch
from
fb2f2c4
to
722cb6c
Compare
xin-hedera
reviewed
Oct 31, 2024
hedera-mirror-grpc/src/main/java/com/hedera/mirror/grpc/listener/SharedTopicListener.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Saai Syvendra <[email protected]>
|
Thanks for the PR. This looks good, but since this is a critical area of code we'll have to scheduled some time to test it in our performance environment before we can merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updated
SharedTopicListenerto use a Sink Implementation from the deprecatedDirectProcessorRelated issue(s):
Fixes #5187
Notes for reviewer:
Updated the above said changes
Checklist