Suppress recoverable error for inactive evm addresses #8536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Edwin Greene <[email protected]>
edwin-greene
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8536 +/- ##
============================================
+ Coverage 92.41% 92.54% +0.12%
+ Complexity 7474 7379 -95
============================================
Files 913 895 -18
Lines 29788 29561 -227
Branches 3622 3613 -9
============================================
- Hits 27529 27356 -173
+ Misses 1440 1384 -56
- Partials 819 821 +2 ☔ View full report in Codecov by Sentry. |
steven-sheehy
requested changes
Jun 12, 2024
...rror-importer/src/main/java/com/hedera/mirror/importer/domain/ContractResultServiceImpl.java
Outdated
Show resolved
Hide resolved
...rror-importer/src/main/java/com/hedera/mirror/importer/domain/ContractResultServiceImpl.java
Outdated
Show resolved
Hide resolved
...rror-importer/src/main/java/com/hedera/mirror/importer/domain/ContractResultServiceImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Edwin Greene <[email protected]>
Signed-off-by: Edwin Greene <[email protected]>
...rror-importer/src/main/java/com/hedera/mirror/importer/domain/ContractResultServiceImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Edwin Greene <[email protected]>
...rror-importer/src/main/java/com/hedera/mirror/importer/domain/ContractResultServiceImpl.java
Outdated
Show resolved
Hide resolved
...rror-importer/src/main/java/com/hedera/mirror/importer/domain/ContractResultServiceImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Edwin Greene <[email protected]>
...-importer/src/test/java/com/hedera/mirror/importer/domain/ContractResultServiceImplTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Edwin Greene <[email protected]>
|
steven-sheehy
approved these changes
Jun 21, 2024
steven-sheehy
deleted the
8290-suppress-recoverable-errors-for-inactive-addresses
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Suppresses recoverable errors when unable to lookup an entity id for an inactive evm address.
Related issue(s):
Fixes #8290
Notes for reviewer:
Checklist