Fix OpenAPI bugs related to path parameters

[longnguyencircle]

Signed-off-by: Long Nguyen [email protected]

Description:

This PR modifies the openapi.yaml spec to fix two bugs.

Fixes

1. The fromQueryPathParam is not valid at all and breaks generated Java code. This is for the /api/v1/contracts/{contractId}/results endpoint, which does not use such a parameter. See https://docs.hedera.com/guides/docs/mirror-node-api/cryptocurrency-api#contract-results.
2. It is not possible to use the arbitrarily defined entityIdPathParam ref for everything. OpenAPI does not know how to replace the name argument, and there is no way to override specific fields after using a ref either. You end up having wrong code that doesn't even call out with the proper arguments. We need to duplicate the schema, but with different names (since we can't override names). See [Question] Extend/override properties of a parameter  OAI/OpenAPI-Specification#2026.

Notes for reviewer:

Please be careful with OpenAPI updates in the future.

[codecov]

Codecov Report

Merging #3132 (f99c419) into main (306f61a) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #3132   +/-   ##
=========================================
  Coverage     88.29%   88.30%           
- Complexity     2392     2393    +1     
=========================================
  Files           485      485           
  Lines         13567    13567           
  Branches       1264     1264           
=========================================
+ Hits          11979    11980    +1     
  Misses         1275     1275           
+ Partials        313      312    -1     

Impacted Files	Coverage Δ
...a/mirror/grpc/listener/CompositeTopicListener.java	83.33% <0.00%> (+4.16%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 306f61a...f99c419. Read the comment docs.

[steven-sheehy]

This looks to be mostly a duplicate of #3108 ?

The fromQueryPathParam issue has already been addressed, I believe.

[longnguyencircle]

Ah, I didn't notice that! That is a big PR too—we noticed this when trying to update our Circle nodes. Thanks so much! I believe this can be closed then. :)

[steven-sheehy]

Ah, I didn't notice that! That is a big PR too—we noticed this when trying to update our Circle nodes. Thanks so much! I believe this can be closed then. :)

Oh, looks like that PR is borked since I last checked after a merge from main. We've closed that one in favor of your PR. Just one change needed. Thanks!

[steven-sheehy]

Revert removal of fromQueryParam. This is a valid parameter that had a wrong name attribute that was fixed in a previous commit. I think that should already address whatever error you were getting if you can confirm.

[steven-sheehy]

LGTM