Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Reduce initial account funding #3256

Merged
merged 1 commit into from
Nov 13, 2024
Merged

chore: Reduce initial account funding #3256

merged 1 commit into from
Nov 13, 2024

Conversation

beeradb
Copy link
Collaborator

@beeradb beeradb commented Nov 13, 2024

This PR reduces the initial account funding for public acceptance tests from 500 to 250hbar.

#3256

Copy link

sonarcloud bot commented Nov 13, 2024

Copy link

github-actions bot commented Nov 13, 2024

Test Results

 18 files  +1  240 suites  +10   33m 53s ⏱️ + 4m 24s
607 tests ±0  598 ✅  -  5  4 💤 ±0  5 ❌ +5 
631 runs  +8  622 ✅ + 3  4 💤 ±0  5 ❌ +5 

For more details on these failures, see this check.

Results for commit 33422a3. ± Comparison against base commit 967270f.

♻️ This comment has been updated with latest results.

@beeradb beeradb changed the title Reduce initial account funding chore: Reduce initial account funding Nov 13, 2024
@beeradb beeradb added this to the 0.61.0 milestone Nov 13, 2024
@beeradb beeradb added the enhancement New feature or request label Nov 13, 2024
Copy link
Contributor

@ebadiere ebadiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG.

@ebadiere ebadiere merged commit ce43b76 into main Nov 13, 2024
46 of 50 checks passed
@ebadiere ebadiere deleted the reduce-initial-funds branch November 13, 2024 17:00
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.44%. Comparing base (9e73aae) to head (33422a3).
Report is 61 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3256      +/-   ##
==========================================
- Coverage   85.53%   79.44%   -6.10%     
==========================================
  Files          45       69      +24     
  Lines        3387     4621    +1234     
  Branches      673     1038     +365     
==========================================
+ Hits         2897     3671     +774     
- Misses        282      607     +325     
- Partials      208      343     +135     
Flag Coverage Δ
config-service 98.14% <ø> (?)
relay 78.58% <ø> (-6.95%) ⬇️
server 83.28% <ø> (?)
ws-server 36.66% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 51 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants