Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry picked #3254 to release/0.60 #3255

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

quiet-node
Copy link
Member

Description:
chore: cherry picked #3254

Related issue(s):

Fixes #3254

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@quiet-node quiet-node added the process Build, test and deployment-process related tasks label Nov 13, 2024
@quiet-node quiet-node added this to the 0.60.0 milestone Nov 13, 2024
@quiet-node quiet-node self-assigned this Nov 13, 2024
Copy link

github-actions bot commented Nov 13, 2024

Test Results

 17 files   -   3  230 suites   - 55   29m 2s ⏱️ - 4m 48s
607 tests ±  0  603 ✅ + 18  4 💤 ±0  0 ❌  - 18 
623 runs   - 174  619 ✅  - 156  4 💤 ±0  0 ❌  - 18 

Results for commit 6f742d0. ± Comparison against base commit 5155a8e.

♻️ This comment has been updated with latest results.

* chore: fix mirror node client

Signed-off-by: nikolay <[email protected]>

* chore: remove .only

Signed-off-by: nikolay <[email protected]>

---------

Signed-off-by: nikolay <[email protected]>
Signed-off-by: Logan Nguyen <[email protected]>
Copy link

sonarcloud bot commented Nov 13, 2024

@quiet-node quiet-node merged commit af6d48f into release/0.60 Nov 13, 2024
44 of 45 checks passed
@quiet-node quiet-node deleted the cherry-pick-3254 branch November 13, 2024 16:20
@quiet-node quiet-node changed the title chore: cherry picked #3254 to release/0.56 chore: cherry picked #3254 to release/0.60 Nov 13, 2024
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.84%. Comparing base (5155a8e) to head (6f742d0).
Report is 1 commits behind head on release/0.60.

Additional details and impacted files
@@               Coverage Diff                @@
##           release/0.60    #3255      +/-   ##
================================================
+ Coverage         77.83%   77.84%   +0.01%     
================================================
  Files                66       66              
  Lines              4457     4460       +3     
  Branches            998     1000       +2     
================================================
+ Hits               3469     3472       +3     
  Misses              613      613              
  Partials            375      375              
Flag Coverage Δ
config-service 98.14% <ø> (ø)
relay 78.58% <100.00%> (+0.01%) ⬆️
server 83.28% <ø> (ø)
ws-server 36.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/relay/src/lib/clients/mirrorNodeClient.ts 86.16% <100.00%> (+0.09%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
process Build, test and deployment-process related tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants