feat: cherry-pick #3177 remove transactions with status INVALID_ACCOUNT_ID from block…
#3217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-specific routes (#3177) * chore: add excluded transaction statuses array Signed-off-by: nikolay <[email protected]> * chore: resolve comments Signed-off-by: nikolay <[email protected]> * chore: resolve comments Signed-off-by: nikolay <[email protected]> * chore: resolve comments Signed-off-by: nikolay <[email protected]> * chore: pull main Signed-off-by: nikolay <[email protected]> * chore: alphabet order Signed-off-by: nikolay <[email protected]> --------- Signed-off-by: nikolay <[email protected]> Signed-off-by: Eric Badiere <[email protected]>
ebadiere
requested review from
AlfredoG87,
lukelee-sl and
a team
as code owners
quiet-node
approved these changes
Nov 5, 2024
|
ebadiere
changed the title
INVALID_ACCOUNT_ID from block…INVALID_ACCOUNT_ID from block…
Test Results 24 files + 2 351 suites +77 38m 57s ⏱️ + 4m 49s For more details on these failures, see this check. Results for commit f37e8ea. ± Comparison against base commit 0ac33d6. ♻️ This comment has been updated with latest results. |
natanasow
approved these changes
Nov 5, 2024
Nana-EC
approved these changes
Nov 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/0.59 #3217 +/- ##
=============================================
Coverage 83.11% 83.12%
=============================================
Files 66 66
Lines 4312 4314 +2
Branches 843 843
=============================================
+ Hits 3584 3586 +2
Misses 485 485
Partials 243 243
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #3177
Fixes issue: #3171
chore: add excluded transaction statuses array
chore: resolve comments
chore: resolve comments
chore: resolve comments
chore: pull main
chore: alphabet order
Description:
Related issue(s):
Fixes #
Notes for reviewer:
Checklist