Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HBAR Rate Limit Redesign] Note what configurations are used #2970

Closed
Tracked by #2739
victor-yanev opened this issue Sep 12, 2024 · 0 comments · Fixed by #3014
Closed
Tracked by #2739

[HBAR Rate Limit Redesign] Note what configurations are used #2970

victor-yanev opened this issue Sep 12, 2024 · 0 comments · Fixed by #3014
Assignees
@victor-yanev
Labels
design Design, pilot and prototyping exploration work documentation Improvements or additions to documentation
Milestone
0.57.0

Comments

@victor-yanev
Copy link
Contributor

victor-yanev commented Sep 12, 2024 •
edited
Loading

Update the design doc to note which configs are used and what new configs were added and their purpose and effect on the design.

Looking at HbarSpendingPlan, I'm curious about the spentToday field.

  1. What was the logic to confine it Today and how is it used?
  2. Are we still using the HBAR_RATE_LIMIT_DURATION config and how does that affect spentToday if the duration is not 1 day?
  3. What are the configurations which will be used to create the spending plans for supported projects & partners
@victor-yanev victor-yanev mentioned this issue Sep 12, 2024
Closed
@victor-yanev victor-yanev moved this from Backlog to Sprint Backlog in Smart Contract Sprint Board Sep 12, 2024
@victor-yanev victor-yanev added documentation Improvements or additions to documentation design Design, pilot and prototyping exploration work labels Sep 12, 2024
@victor-yanev victor-yanev added this to the 0.56.0 milestone Sep 12, 2024
@quiet-node quiet-node modified the milestones: 0.56.0, 0.57.0 Sep 17, 2024
@victor-yanev victor-yanev self-assigned this Sep 19, 2024
@victor-yanev victor-yanev moved this from Sprint Backlog to Tasks In Progress in Smart Contract Sprint Board Sep 19, 2024
@victor-yanev victor-yanev mentioned this issue Sep 19, 2024
Merged
2 tasks
@victor-yanev victor-yanev moved this from Tasks In Progress to In Review in Smart Contract Sprint Board Sep 19, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Smart Contract Sprint Board Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@victor-yanev victor-yanev

Labels
design Design, pilot and prototyping exploration work documentation Improvements or additions to documentation
Projects
Smart Contract Sprint Board
Status: Done
Milestone
0.57.0
Development

Successfully merging a pull request may close this issue.

refactor: configurations of HbarLimitService hashgraph/hedera-json-rpc-relay
2 participants
@quiet-node @victor-yanev