Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HBAR Rate Limit Redesign] Redesign of the HBar Rate Limiter #2739

Closed
17 tasks done
ebadiere opened this issue Jul 23, 2024 · 2 comments
Closed
17 tasks done

[HBAR Rate Limit Redesign] Redesign of the HBar Rate Limiter #2739

ebadiere opened this issue Jul 23, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request Epic
Milestone

Comments

@ebadiere
Copy link
Contributor

ebadiere commented Jul 23, 2024

Problem

The current HBar rate limiter is designed to limit the operator HBar spending over a duration such as a minute, but the relay may get batches of many FileAppend transactions that disproportionally spend the relay's operator balance. Reducing the remaining balance in the HBar rate limiter can stop the many incoming FileAppend transactions but can also stop other users from simply deploying transactions.

Solution

Redesign the HBar rate limiter

Consider:

  • Rate limiting using the operator's quota for the day. Query the mirror node for updated operator balance at regular intervals.
  • Limit the FileAppend per user of IP
  • Define requirements

Alternatives

No response

Tasks

  1. design enhancement
    konstantinabl
  2. 10 of 10
    Epic enhancement
    Ivo-Yankov ebadiere
    konstantinabl quiet-node victor-yanev
  3. 2 of 2
    enhancement
    quiet-node
  4. enhancement
    quiet-node
  5. 2 of 2
    enhancement
    victor-yanev
  6. enhancement
    konstantinabl
  7. design documentation
    victor-yanev
  8. design documentation
    victor-yanev
  9. design enhancement
    victor-yanev
  10. enhancement
    victor-yanev
  11. P1 enhancement
    victor-yanev
  12. 5 of 5
    Epic enhancement
    konstantinabl quiet-node
  13. P1 bug
    victor-yanev
  14. P1 enhancement
    victor-yanev
  15. enhancement
    ebadiere
  16. enhancement
    victor-yanev
@ebadiere ebadiere added the enhancement New feature or request label Jul 23, 2024
@quiet-node quiet-node self-assigned this Aug 19, 2024
@quiet-node quiet-node moved this from Backlog to Epics In Progress in Smart Contract Sprint Board Aug 19, 2024
@quiet-node quiet-node changed the title Redesign of the HBar rate limiter [HBAR Rate Limit Redesign] Redesign of the HBar Rate Limiter Oct 4, 2024
@quiet-node quiet-node added this to the 0.59.0 milestone Oct 16, 2024
@Nana-EC
Copy link
Collaborator

Nana-EC commented Nov 11, 2024

Moving #3109 (unrelated) and #3099 (not required right now) out of EPIC

@Nana-EC
Copy link
Collaborator

Nana-EC commented Nov 11, 2024

Great job team.
Closing this off

@Nana-EC Nana-EC closed this as completed Nov 11, 2024
@github-project-automation github-project-automation bot moved this from Epics In Progress to Done in Smart Contract Sprint Board Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Epic
Projects
Status: Done
Development

No branches or pull requests

7 participants