feat: fix wrong cache key on eth_getBlockByHash (#3232)

* chore: fix wrong passed param Signed-off-by: nikolay <[email protected]> * chore: modify existing test to handle block_ properties as well Signed-off-by: nikolay <[email protected]> --------- Signed-off-by: nikolay <[email protected]>
hashgraph · Nov 7, 2024 · fe9fcf0 · fe9fcf0
1 parent acc4538
commit fe9fcf0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/packages/relay/src/lib/eth.ts b/packages/relay/src/lib/eth.ts
@@ -2089,7 +2089,7 @@ export class EthImpl implements Eth {
       );
       return receipt;
     } else {
-      const effectiveGas = await this.getCurrentGasPriceForBlock(receiptResponse.blockHash, requestDetails);
+      const effectiveGas = await this.getCurrentGasPriceForBlock(receiptResponse.block_hash, requestDetails);
       // support stricter go-eth client which requires the transaction hash property on logs
       const logs = receiptResponse.logs.map((log) => {
         return new Log({

diff --git a/packages/relay/tests/lib/mirrorNodeClient.spec.ts b/packages/relay/tests/lib/mirrorNodeClient.spec.ts
@@ -574,6 +574,9 @@ describe('MirrorNodeClient', async function () {
     expect(result.to).equal(detailedContractResult.to);
     expect(result.v).equal(detailedContractResult.v);
     expect(result.transaction_index).equal(detailedContractResult.transaction_index);
+    expect(result.block_gas_used).equal(detailedContractResult.block_gas_used);
+    expect(result.block_number).equal(detailedContractResult.block_number);
+    expect(result.block_hash).equal(detailedContractResult.block_hash);
     expect(mock.history.get.length).to.eq(1); // is called once
   });