hotfix/mobile-menu-alignment #2333
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PensoGlide
force-pushed
the
hotfix/mobile-menu-alignment
branch
from
e1be278
to
ab97cd5
Compare
simvalery
reviewed
Jun 26, 2023
| mobileMenuFix(): void { | ||
| if (this.innerWidth <= 810) { | ||
| setTimeout(function () { | ||
| window.location.reload(); |
There was a problem hiding this comment.
location.reload is bad practice, need normal fix using css styles
PensoGlide
force-pushed
the
hotfix/mobile-menu-alignment
branch
from
ab97cd5
to
0a975dd
Compare
|
|
PensoGlide
force-pushed
the
hotfix/mobile-menu-alignment
branch
from
0a975dd
to
4785f2c
Compare
I have implemented a fix for one of the ticket issues (d73bf6b), this is an example of the recommended approach - please take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR solves the issues where the "Policy Viewer" and the "Policy Editor" submenus would overlap with the rest of the menu on mobile.
Solves issue #2064 .