feat(cli): allow deploying different number network nodes #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #726 +/- ##
===========================================
+ Coverage 0 67.51% +67.51%
- Complexity 0 339 +339
===========================================
Files 0 64 +64
Lines 0 1336 +1336
Branches 0 157 +157
===========================================
+ Hits 0 902 +902
- Misses 0 371 +371
- Partials 0 63 +63 see 64 files with indirect coverage changes |
Signed-off-by: Lenin Mehedy <[email protected]>
Signed-off-by: Lenin Mehedy <[email protected]>
Signed-off-by: Lenin Mehedy <[email protected]>
leninmehedy
force-pushed
the
582-Allow-deploying-different-number-network-nodes
branch
2 times, most recently
from
3786943 to
1b4af8a
Compare
Signed-off-by: Lenin Mehedy <[email protected]>
leninmehedy
force-pushed
the
582-Allow-deploying-different-number-network-nodes
branch
from
1b4af8a to
7c43e81
Compare
…it command Signed-off-by: Lenin Mehedy <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Jeromy Cannon <[email protected]>
Signed-off-by: Lenin Mehedy <[email protected]>
…user > cached config > defaults (#731) Signed-off-by: Jeromy Cannon <[email protected]>
…t tests (#729) Signed-off-by: Lenin Mehedy <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]> Co-authored-by: Jeromy Cannon <[email protected]>
Signed-off-by: Lenin Mehedy <[email protected]>
leninmehedy
force-pushed
the
582-Allow-deploying-different-number-network-nodes
branch
from
ee2357e to
fd01b4f
Compare
|
jeromy-cannon
approved these changes
Feb 3, 2024
leninmehedy
deleted the
582-Allow-deploying-different-number-network-nodes
branch
swirlds-automation
added a commit
that referenced
this pull request
Feb 5, 2024
## [0.20.0](v0.19.1...v0.20.0) (2024-02-05) ### Features * **cli:** allow deploying different number network nodes ([#726](#726)) ([410d499](410d499)) * **cli:** generate Gossip keys and gRPC TLS keys in PEM format ([#629](#629)) ([d970796](d970796)) ### Bug Fixes * update solo readme with examples ([#725](#725)) ([dd8bbd7](dd8bbd7))
|
🎉 This PR is included in version 0.20.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We can now just set the node IDs to deploy different number of network nodes,
e.g.
solo network deploy -i node0,node1,node2,node3,node4......nodeNThis pull request changes the following:
--devflag is setRelated Issues