feat: convert chart tests from the custom bash script to be BATS unit tests #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lenin Mehedy <[email protected]>
leninmehedy
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #256 +/- ##
=========================================
Coverage 62.23% 62.23%
Complexity 254 254
=========================================
Files 47 47
Lines 1046 1046
Branches 130 130
=========================================
Hits 651 651
Misses 344 344
Partials 51 51 |
Signed-off-by: Lenin Mehedy <[email protected]>
Signed-off-by: Lenin Mehedy <[email protected]>
Signed-off-by: Lenin Mehedy <[email protected]>
Signed-off-by: Lenin Mehedy <[email protected]>
Signed-off-by: Lenin Mehedy <[email protected]>
leninmehedy
force-pushed
the
214-suppport-bats-unit-tests
branch
from
9bbef46 to
b190fa3
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Signed-off-by: Lenin Mehedy <[email protected]>
Base automatically changed from
218-add-support-for-multiple-test-files
to
main
August 8, 2023 03:13
Signed-off-by: Lenin Mehedy <[email protected]>
Signed-off-by: Lenin Mehedy <[email protected]> # Conflicts: # charts/hedera-network/config-files/test.sh # charts/hedera-network/templates/configmaps/test-cm.yaml # charts/hedera-network/templates/tests/test-deployment.yaml # charts/hedera-network/tests/helper.sh # charts/hedera-network/tests/test_basic_deployment.bats
Signed-off-by: Lenin Mehedy <[email protected]>
Signed-off-by: Lenin Mehedy <[email protected]>
Signed-off-by: Lenin Mehedy <[email protected]>
Signed-off-by: Lenin Mehedy <[email protected]>
Signed-off-by: Lenin Mehedy <[email protected]>
nathanklick
approved these changes
Aug 8, 2023
swirlds-automation
added a commit
that referenced
this pull request
Aug 9, 2023
## [0.6.0](v0.5.0...v0.6.0) (2023-08-09) ### Features * convert chart tests from the custom bash script to be BATS unit tests ([#256](#256)) ([0bcdfcb](0bcdfcb)) * update partial templates to match naming conventions and prefix with fullstack namespace ([#265](#265)) ([fb73b5d](fb73b5d)) ### Bug Fixes * correct KeyValuePair equals and add coverage for ServiceLocator ([#257](#257)) ([5b17978](5b17978)) * default tag is not set properly for proxy containers ([#266](#266)) ([deabd16](deabd16)) * enable overriding individual properties for sidecars ([#250](#250)) ([7d5a4e1](7d5a4e1)) * only allow jrs profile during node setup ([#249](#249)) ([dd326c1](dd326c1)) * typo in the semantic release config preventing the updates to Chart.yaml from being committed ([#252](#252)) ([02a576b](02a576b)) * update verification script so that CI pipeline fails if node fails to start ([#254](#254)) ([7f051c0](7f051c0))
|
🎉 This PR is included in version 0.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request changes the following:
Note
This PR is going to fail the unit tests since it requires a docker image that is included in this change.
Related Issues