Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolves the issues caused by the environment variable not being passed to the service scripts #235

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

nathanklick
Copy link
Member

@nathanklick nathanklick commented Aug 3, 2023

Description

This pull request changes the following:

  • Updates the container image definition to properly pass the environment variables to the service script.

Related Issues

Required Cherry Picks

  • main

@nathanklick nathanklick self-assigned this Aug 3, 2023
@nathanklick nathanklick added the Bug A error that causes the feature to behave differently than what was expected based on design docs label Aug 3, 2023
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

Unit Test Results

38 tests   35 ✔️  27s ⏱️
  9 suites    3 💤
  9 files      0

Results for commit 80fba9c.

@nathanklick nathanklick marked this pull request as ready for review August 3, 2023 16:34
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release/0.4@3ca8fe1). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##             release/0.4     #235   +/-   ##
==============================================
  Coverage               ?   56.70%           
  Complexity             ?      144           
==============================================
  Files                  ?       36           
  Lines                  ?      723           
  Branches               ?       73           
==============================================
  Hits                   ?      410           
  Misses                 ?      281           
  Partials               ?       32           

Impacted file tree graph

@nathanklick nathanklick changed the title fix: resolves the issues caused by the environment variable not being passed to the service scripts fix: resolves the issues caused by the environment variable not being passed to the service scripts Aug 3, 2023
@nathanklick nathanklick merged commit 266646d into release/0.4 Aug 3, 2023
nathanklick added a commit that referenced this pull request Aug 3, 2023
… passed to the service scripts (#235)

Signed-off-by: Nathan Klick <[email protected]>
@nathanklick nathanklick deleted the 00234-AppHome-Fix branch August 3, 2023 17:00
swirlds-automation added a commit that referenced this pull request Aug 4, 2023
## [0.5.0](v0.4.0...v0.5.0) (2023-08-04)

### Features

* add CI pipeline tests for network node helm installation ([#228](#228)) ([3e665f3](3e665f3))
* add service locator API initial draft ([#230](#230)) ([1e81f65](1e81f65))
* for the hedera-network Helm chart set the minimum Kubernetes server version ([#231](#231)) ([de9aceb](de9aceb))

### Bug Fixes

*  use reasonable defaults for the per node configuration in the values.yaml file ([#229](#229)) ([92032f9](92032f9))
* resolves the issues caused by the environment variable not being passed to the service scripts ([#235](#235)) ([022b03d](022b03d))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A error that causes the feature to behave differently than what was expected based on design docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants